From: Dirk Behme <dirk.behme@gmail.com>
To: linux-serial@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>,
Huang Shijie <b32955@freescale.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Wang, Jiada" <Jiada_Wang@mentor.com>,
Dirk Behme <dirk.behme@de.bosch.com>
Subject: Mainline commit "serial: Test for no tx data on tx restart" not correct for i.MX6?
Date: Wed, 23 Jul 2014 06:10:01 +0200 [thread overview]
Message-ID: <53CF3599.6040509@gmail.com> (raw)
Hi,
this is a question regarding the i.MX6 part (drivers/tty/serial/imx.c)
of the commit
serial: Test for no tx data on tx restart
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c557d392fbf5badd693ea1946a4317c87a26a716
Talking with some i.MX6 experts about this, I've got the comment
-- cut --
The imx serial driver part of this commit isn't correct
as imx.c sends x_char in irq handler, not in imx_start_tx(),
-- cut --
What do you think?
Best regards
Dirk
P.S.: I don't have the initial post in my inbox, so sorry for the new
thread.
next reply other threads:[~2014-07-23 4:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 4:10 Dirk Behme [this message]
2014-07-23 16:32 ` Mainline commit "serial: Test for no tx data on tx restart" not correct for i.MX6? Peter Hurley
2014-07-24 8:12 ` jiwang
2014-07-24 11:58 ` Peter Hurley
2014-07-29 7:18 ` jiwang
2014-08-06 23:53 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF3599.6040509@gmail.com \
--to=dirk.behme@gmail.com \
--cc=Jiada_Wang@mentor.com \
--cc=aaro.koskinen@iki.fi \
--cc=b32955@freescale.com \
--cc=dirk.behme@de.bosch.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).