From: Peter Hurley <peter@hurleysoftware.com>
To: Daniel Thompson <daniel.thompson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, patches@linaro.org,
linaro-kernel@lists.linaro.org,
Russell King <linux@arm.linux.org.uk>,
Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 3.17-rc3] serial: amba-pl011: Use container_of() to get uart_amba_port
Date: Thu, 11 Sep 2014 07:25:29 -0400 [thread overview]
Message-ID: <541186A9.902@hurleysoftware.com> (raw)
In-Reply-To: <1409745115-1423-1-git-send-email-daniel.thompson@linaro.org>
On 09/03/2014 07:51 AM, Daniel Thompson wrote:
> Universally adopt container_of() for all pointer conversion from
> uart_port to uart_amba_port.
Thanks.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Peter Hurley <peter@hurleysoftware.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: linux-serial@vger.kernel.org
> ---
>
> Notes:
> This patch was written after a review comment made by Peter Hurley in
> response to code that is no longer needed. However I'd already written
> it before I realized the code was no longer needed and it still appears
> to be a sensible, if rather minor, bit of modernization.
>
>
> drivers/tty/serial/amba-pl011.c | 54 +++++++++++++++++++++++++++--------------
> 1 file changed, 36 insertions(+), 18 deletions(-)
prev parent reply other threads:[~2014-09-11 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 11:51 [PATCH 3.17-rc3] serial: amba-pl011: Use container_of() to get uart_amba_port Daniel Thompson
2014-09-11 11:25 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541186A9.902@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=daniel.thompson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).