Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Jingchang Lu <jingchang.lu@freescale.com>, gregkh@linuxfoundation.org
Cc: arnd@arndb.de, Joseph Lo <josephl@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] serial: of-serial: fix up PM ops on no_console_suspend
Date: Thu, 09 Oct 2014 22:04:51 -0700	[thread overview]
Message-ID: <543768F3.6090703@wwwdotorg.org> (raw)
In-Reply-To: <1412845852-26157-1-git-send-email-jingchang.lu@freescale.com>

On 10/09/2014 02:10 AM, Jingchang Lu wrote:
> Mandatorily disabling the uart clock will cause register access
> hung on "no_console_suspend". This patch add condition check on
> it and only disable the clock with console_suspend_enabled true.

It would be useful if the email/patch subject line said "V2", and there
was a changelog below.

> Signed-off-by: Joseph Lo <josephl@nvidia.com>

I don't think he did; he just suggested a small fix.

> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> ---
>  drivers/tty/serial/of_serial.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
...

  reply	other threads:[~2014-10-10  5:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09  9:10 [PATCH] serial: of-serial: fix up PM ops on no_console_suspend Jingchang Lu
2014-10-10  5:04 ` Stephen Warren [this message]
2014-10-10  6:16   ` Jingchang Lu
2014-10-10 10:25     ` Peter Hurley
2014-10-10 11:39 ` Peter Hurley
2014-10-11  3:37   ` Jingchang Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543768F3.6090703@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jingchang.lu@freescale.com \
    --cc=josephl@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox