linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: frowand.list@gmail.com
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: msm_serial: Use DT aliases
Date: Mon, 10 Nov 2014 18:20:01 -0800	[thread overview]
Message-ID: <54617251.10306@gmail.com> (raw)
In-Reply-To: <545C4E1F.4060401@gmail.com>

From: Frank Rowand <frank.rowand@sonymobile.com>

v2, changes from v1:
  - The patch this documents was updated to make the serialN alias
    optional instead of required.

Update devicetree binding for msm_serial to reflect msm_serial_probe()
getting line id from the serial alias.

Signed-off-by: Frank Rowand <frank.rowand@sonymobile.com>
---
 Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt |   15 +++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

Index: linux/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
===================================================================
--- linux.orig/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
+++ linux/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
@@ -27,11 +27,21 @@ Optional properties:
 - dmas: Should contain dma specifiers for transmit and receive channels
 - dma-names: Should contain "tx" for transmit and "rx" for receive channels
 
+Note: Each UART port should have an alias correctly numbered in the
+"aliases" node, according to serialN format, where N is the port number
+(non-negative decimal integer).  If the aliases are not present then
+the port numbers will be 0..(number of UARTS - 1), assigned in the driver
+probe order.
+
 Examples:
 
 A uartdm v1.4 device with dma capabilities.
 
-serial@f991e000 {
+aliases {
+	serial0 = &serial0;
+};
+
+serial0: serial@f991e000 {
 	compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
 	reg = <0xf991e000 0x1000>;
 	interrupts = <0 108 0x0>;
@@ -43,7 +53,11 @@ serial@f991e000 {
 
 A uartdm v1.3 device without dma capabilities and part of a GSBI complex.
 
-serial@19c40000 {
+aliases {
+	serial0 = &serial0;
+};
+
+serial0: serial@19c40000 {
 	compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm";
 	reg = <0x19c40000 0x1000>,
 	      <0x19c00000 0x1000>;

  parent reply	other threads:[~2014-11-11  2:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23  0:33 [PATCH] tty: serial: msm_serial: Use DT aliases Stephen Boyd
2014-11-07  4:44 ` Frank Rowand
2014-11-10 23:53   ` Stephen Boyd
2014-11-11  2:20   ` Frank Rowand [this message]
2014-11-11  2:23     ` Stephen Boyd
2014-11-07  6:40 ` Frank Rowand
2014-11-07  6:42   ` Frank Rowand
2014-11-07  9:47     ` Arnd Bergmann
2014-11-07 21:35       ` Frank Rowand
2014-11-08 19:25         ` Arnd Bergmann
2014-11-10 18:54 ` Kevin Hilman
2014-11-10 19:42   ` Stephen Boyd
2014-11-11  1:56     ` Frank Rowand
2014-11-11  2:07       ` Stephen Boyd
2014-11-11  3:20         ` Frank Rowand
2014-11-12 18:14           ` Frank Rowand
2014-11-13 19:31             ` Stephen Boyd
2014-11-14  0:46               ` Frank Rowand
2014-11-14  0:59                 ` Stephen Boyd
2014-11-14 17:43                   ` Kevin Hilman
2014-11-14 18:33                     ` Stephen Boyd
2014-11-11 15:31     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54617251.10306@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).