From: "Janusz Użycki" <j.uzycki@elproma.com.pl>
To: Rojhalat Ibrahim <imr@rtschenk.de>
Cc: Richard Genoud <richard.genoud@gmail.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH][RESEND] serial_mctrl_gpio: use gpiod_set_array function
Date: Wed, 19 Nov 2014 23:41:06 +0100 [thread overview]
Message-ID: <546D1C82.4020808@elproma.com.pl> (raw)
In-Reply-To: <8534699.OPo8bzguux@pcimr>
Hello.
Good patch but I'd prefer to introduce separate function for mctrl_gpio.
I'm not conviced whether it is useful for 2 gpio lines (outputs: RTS,
DTR) of mctrl_gpio.
It adds some overhead for all drivers which use mctrl_gpio but likely
they don't require it.
best regards
Janusz
next prev parent reply other threads:[~2014-11-19 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 17:31 [PATCH][RESEND] serial_mctrl_gpio: use gpiod_set_array function Rojhalat Ibrahim
2014-11-19 22:41 ` Janusz Użycki [this message]
2014-11-25 17:40 ` Greg Kroah-Hartman
2014-11-28 13:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546D1C82.4020808@elproma.com.pl \
--to=j.uzycki@elproma.com.pl \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imr@rtschenk.de \
--cc=linus.walleij@linaro.org \
--cc=linux-serial@vger.kernel.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox