From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH] Revert "tty: Fix pty master poll() after slave closes v2" Date: Tue, 06 Jan 2015 15:33:05 +0100 Message-ID: <54ABF221.7000305@suse.cz> References: <1419941829-6536-1-git-send-email-peter@hurleysoftware.com> <54A29B0A.3060707@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54A29B0A.3060707@hurleysoftware.com> Sender: linux-kernel-owner@vger.kernel.org To: Peter Hurley , Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Ruggeri , Francesco Ruggeri List-Id: linux-serial@vger.kernel.org On 12/30/2014, 01:31 PM, Peter Hurley wrote: > On 12/30/2014 07:17 AM, Peter Hurley wrote: >> This reverts commit c4dc304677e8d566572c4738d95c48be150c6606. >> This fix is superseded by commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73, >> 'pty, n_tty: Simplify input processing on final close'. >> >> The final close now waits for input processing to complete before >> destroying the pty, so poll() does not need to special case this >> condition. > > Greg, > > As noted in this commit log, commit c4dc304677e8d566572c4738d95c48be150c6606, > 'tty: Fix pty master poll() after slave closes v2', is not required > after commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73, > 'pty, n_tty: Simplify input processing on final close' > > However, 'tty: Fix pty master poll() after slave closes v2' is appropriate > for stable back to v3.12. Now applied to 3.12. A backport was needed due to the later change of the input_available_p 2nd parameter. thanks, -- js suse labs