From: Stephen Boyd <sboyd@codeaurora.org>
To: Pramod Gurav <pramod.gurav@smartplayin.com>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tty: serial: msm_serial: code cleanup in msm_console_setup
Date: Mon, 12 Jan 2015 16:24:16 -0800 [thread overview]
Message-ID: <54B465B0.6080206@codeaurora.org> (raw)
In-Reply-To: <1421070332-24420-1-git-send-email-pramod.gurav@smartplayin.com>
On 01/12/2015 05:45 AM, Pramod Gurav wrote:
> The change does following:
> - baud, flow, bits, parity were being overwritten as they were
> being reinitialized after parsing. Initialize them when they are
> declared so that user provided setting are not overwritten.
> - msm_set_baud_rate() is anyway called in uart_set_options when it calls
> msm_set_termios(). msm_reset() is called when we change the baud rate.
> Hence doing away with both of these calls.
> - CR_CMD_PROTECTION_EN and CR_TX_ENABLE settings are done in msm_set_baud_rate.
> So do away with this here.
>
> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-01-13 0:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 13:45 [PATCH v3] tty: serial: msm_serial: code cleanup in msm_console_setup Pramod Gurav
2015-01-13 0:24 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B465B0.6080206@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pramod.gurav@smartplayin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).