* [PATCH] tty: serial: msm_serial: Remove console unregistration from driver exit.
@ 2015-01-12 13:52 Pramod Gurav
2015-01-13 0:26 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Pramod Gurav @ 2015-01-12 13:52 UTC (permalink / raw)
To: Stephen Boyd
Cc: David Brown, Daniel Walker, Bryan Huntsman, Greg Kroah-Hartman,
Jiri Slaby, linux-arm-msm, linux-serial, linux-kernel,
Pramod Gurav
unregister_console() will be called from uart_remove_one_port() while
removing the platform driver. So not necessary to call it in driver
exit path.
Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
---
drivers/tty/serial/msm_serial.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 8a7af98..58ba602 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -1298,9 +1298,6 @@ static int __init msm_serial_init(void)
static void __exit msm_serial_exit(void)
{
-#ifdef CONFIG_SERIAL_MSM_CONSOLE
- unregister_console(&msm_console);
-#endif
platform_driver_unregister(&msm_platform_driver);
uart_unregister_driver(&msm_uart_driver);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tty: serial: msm_serial: Remove console unregistration from driver exit.
2015-01-12 13:52 [PATCH] tty: serial: msm_serial: Remove console unregistration from driver exit Pramod Gurav
@ 2015-01-13 0:26 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2015-01-13 0:26 UTC (permalink / raw)
To: Pramod Gurav
Cc: David Brown, Daniel Walker, Bryan Huntsman, Greg Kroah-Hartman,
Jiri Slaby, linux-arm-msm, linux-serial, linux-kernel
On 01/12/2015 05:52 AM, Pramod Gurav wrote:
> unregister_console() will be called from uart_remove_one_port() while
> removing the platform driver. So not necessary to call it in driver
> exit path.
>
> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-12 13:52 [PATCH] tty: serial: msm_serial: Remove console unregistration from driver exit Pramod Gurav
2015-01-13 0:26 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).