From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH 2/2] tty: serial: 8250_core: Check that port->line is >=0 Date: Fri, 16 Jan 2015 11:51:12 +0100 Message-ID: <54B8ED20.60308@linutronix.de> References: <3293c93689f5d8c684133a9d9952411a201609dc.1421333585.git.michal.simek@xilinx.com> <54B8D32E.5000805@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, Jiri Slaby , Peter Hurley , Alan Cox , Tony Lindgren , Ricardo Ribalda Delgado , Andy Shevchenko , Ingo Molnar List-Id: linux-serial@vger.kernel.org - Yoshihiro YUNOMAE (reason: 550 5.1.1 : Recipient address rejected: User Unknown) On 01/16/2015 11:37 AM, Michal Simek wrote: > Hi, Hi, > Origin patch looks good to me but this checking will be good to add. > Are you using of_serial.c because I didn't find any of_alias_get_id call > for 8250? I'm using of_alias_get_id() in 8250_omap.c which made it into v3.19-rc1. I think the change you mention made it one release earlier. > Your logic here is a little bit different than I have in my tree. > (Some sort of pl011 solution). You don't need to failed if you port.line is > below 0 but if you are not able to read aliases port enumeration > may be unpredictable. For omap we should have valid aliases because we have multiple UARTs. So the platform id should always be >=0 and the DT includes it already. And Tony wanted to have predicted numbers so I don't mind to fail here. Also it is nice if you have ttyS2 which maps UART2 in the manual even without having ttyS[01]. > Thanks, > Michal Sebastian