From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] serial: sh-sci: Fix R-Car SCIF and HSCIF overrun handling
Date: Sun, 25 Jan 2015 19:57:09 +0300 [thread overview]
Message-ID: <54C52065.8030600@cogentembedded.com> (raw)
In-Reply-To: <1422200281-22518-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 01/25/2015 06:38 PM, Yoshihiro Kaneko wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> When fifo overrun happened, the interrupt status refers to
> SCLSR register in R-Car SCIF and HSCIF.
> Thus, overrun handling takes SCLSR register into account.
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
[...]
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 8204306..69f6bf3 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
[...]
> @@ -1032,6 +1038,12 @@ static irqreturn_t sci_mpxed_interrupt(int irq, void *ptr)
> if ((ssr_status & SCxSR_BRK(port)) && err_enabled)
> ret = sci_br_interrupt(irq, ptr);
>
> + /* Overrun Interrupt */
> + if (port->type == PORT_SCIF || port->type == PORT_HSCIF) {
> + if ((slr_status & 0x01))
No need for double parens.
WBR, Sergei
prev parent reply other threads:[~2015-01-25 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 15:38 [PATCH] serial: sh-sci: Fix R-Car SCIF and HSCIF overrun handling Yoshihiro Kaneko
2015-01-25 16:57 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C52065.8030600@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).