From: "long.wanglong" <long.wanglong@huawei.com>
To: Wang Long <long.wanglong@huawei.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz,
bigeasy@linutronix.de, peter@hurleysoftware.com,
tony@atomide.com, alan@linux.intel.com,
ricardo.ribalda@gmail.com, yoshihiro.yunomae.ez@hitachi.com,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
Vineet.Gupta1@synopsys.com, wsa@the-dreams.de, dforsi@gmail.com,
rafael.j.wysocki@intel.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, peifeiyue@huawei.com
Subject: Re: [PATCH] serial: 8250: remove the redundant include
Date: Mon, 9 Mar 2015 12:06:02 +0800 [thread overview]
Message-ID: <54FD1C2A.2070703@huawei.com> (raw)
In-Reply-To: <1425874376-153286-1-git-send-email-long.wanglong@huawei.com>
On 2015/3/9 12:12, Wang Long wrote:
> The serial_core.h file have been included in header file
> serial_8250.h. so remove the "#include <serial_core.h>" in
> some 8250 serial drivers, because they have included the header file
> serial_8250.h.
missing the 8250_dw.c. i will send another patch.
Thanks
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
> drivers/tty/serial/8250/8250_core.c | 1 -
> drivers/tty/serial/8250/8250_early.c | 1 -
> drivers/tty/serial/8250/8250_em.c | 1 -
> drivers/tty/serial/8250/8250_hp300.c | 1 -
> drivers/tty/serial/8250/8250_omap.c | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index e3b9570a..7ddd668 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -31,7 +31,6 @@
> #include <linux/tty.h>
> #include <linux/ratelimit.h>
> #include <linux/tty_flip.h>
> -#include <linux/serial_core.h>
> #include <linux/serial.h>
> #include <linux/serial_8250.h>
> #include <linux/nmi.h>
> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
> index c31a22b..c7ae647 100644
> --- a/drivers/tty/serial/8250/8250_early.c
> +++ b/drivers/tty/serial/8250/8250_early.c
> @@ -29,7 +29,6 @@
> #include <linux/tty.h>
> #include <linux/init.h>
> #include <linux/console.h>
> -#include <linux/serial_core.h>
> #include <linux/serial_reg.h>
> #include <linux/serial.h>
> #include <linux/serial_8250.h>
> diff --git a/drivers/tty/serial/8250/8250_em.c b/drivers/tty/serial/8250/8250_em.c
> index ae5eaed..0b63812 100644
> --- a/drivers/tty/serial/8250/8250_em.c
> +++ b/drivers/tty/serial/8250/8250_em.c
> @@ -21,7 +21,6 @@
> #include <linux/io.h>
> #include <linux/module.h>
> #include <linux/serial_8250.h>
> -#include <linux/serial_core.h>
> #include <linux/serial_reg.h>
> #include <linux/platform_device.h>
> #include <linux/clk.h>
> diff --git a/drivers/tty/serial/8250/8250_hp300.c b/drivers/tty/serial/8250/8250_hp300.c
> index b488208..2891958 100644
> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
> @@ -10,7 +10,6 @@
> #include <linux/string.h>
> #include <linux/kernel.h>
> #include <linux/serial.h>
> -#include <linux/serial_core.h>
> #include <linux/serial_8250.h>
> #include <linux/delay.h>
> #include <linux/dio.h>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index fe6d2e51..9289999 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -11,7 +11,6 @@
> #include <linux/io.h>
> #include <linux/module.h>
> #include <linux/serial_8250.h>
> -#include <linux/serial_core.h>
> #include <linux/serial_reg.h>
> #include <linux/tty_flip.h>
> #include <linux/platform_device.h>
>
prev parent reply other threads:[~2015-03-09 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 4:12 [PATCH] serial: 8250: remove the redundant include Wang Long
2015-03-09 4:06 ` long.wanglong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD1C2A.2070703@huawei.com \
--to=long.wanglong@huawei.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=dforsi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peifeiyue@huawei.com \
--cc=peter@hurleysoftware.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ricardo.ribalda@gmail.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.yunomae.ez@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).