From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Zhen Subject: Re: [PATCH] serial: 8250: fix a sparse warning Date: Mon, 9 Mar 2015 17:02:14 +0800 Message-ID: <54FD6196.60200@huawei.com> References: <1425886615-78601-1-git-send-email-zhenzhang.zhang@huawei.com> <54FD4EE6.7000408@huawei.com> <20150309082253.GA14349@kroah.com> <54FD5C9C.4080609@huawei.com> <20150309085316.GA9131@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150309085316.GA9131@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, tim.kryger@linaro.org, jamie@jamieiles.com, alan@linux.intel.com, arnd@arndb.de List-Id: linux-serial@vger.kernel.org On 2015/3/9 16:53, Greg KH wrote: > On Mon, Mar 09, 2015 at 04:41:00PM +0800, Zhang Zhen wrote: >> On 2015/3/9 16:22, Greg KH wrote: >>> On Mon, Mar 09, 2015 at 03:42:30PM +0800, Zhang Zhen wrote: >>>> drivers/tty/serial/8250/8250_core.c: In function =E2=80=98serial82= 50_console_write=E2=80=99: >>>> drivers/tty/serial/8250/8250_core.c:3244: warning: =E2=80=98flags=E2= =80=99 may be used u >>>> unitialized in this function >>>> >>>> Signed-off-by: Zhang Zhen >>>> --- >>>> drivers/tty/serial/8250/8250_core.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/ser= ial/8250/8250_core.c >>>> index deae122..50702e2 100644 >>>> --- a/drivers/tty/serial/8250/8250_core.c >>>> +++ b/drivers/tty/serial/8250/8250_core.c >>>> @@ -3241,7 +3241,7 @@ serial8250_console_write(struct console *co,= const char *s, unsigned int count) >>>> { >>>> struct uart_8250_port *up =3D &serial8250_ports[co->index]; >>>> struct uart_port *port =3D &up->port; >>>> - unsigned long flags; >>>> + unsigned long flags =3D 0; >>>> unsigned int ier; >>>> int locked =3D 1; >>>> >>> >>> Sparse generated this? Or did a broken / old version of gcc? >>> >> Sorry, it's a gcc warning. >> >> My gcc version is: >> gcc (SUSE Linux) 4.3.4 [gcc-4_3-branch revision 152973] >=20 > That's really old and obsolete, please use a modern version of gcc, > especially when sending in patches for compiler warnings. >=20 Ok, thanks! > greg k-h >=20 > . >=20