From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH] serial: 8250: do not copy port.fifosize member twice Date: Thu, 07 May 2015 06:12:03 -0400 Message-ID: <554B3A73.2000305@hurleysoftware.com> References: <1430993086-15652-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1430993086-15652-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: linux-serial@vger.kernel.org, Sebastian Andrzej Siewior , Jiri Slaby , Alan Cox , Andy Shevchenko , linux-kernel@vger.kernel.org, Ricardo Ribalda Delgado , Tony Lindgren , Greg Kroah-Hartman , Yoshihiro YUNOMAE List-Id: linux-serial@vger.kernel.org On 05/07/2015 06:04 AM, Masahiro Yamada wrote: > The port.fifosize member has already been copied at 8 lines above. > Maybe the compiler optimization can clean it away, but just in case. Reviewed-by: Peter Hurley