* [PATCH] serial: 8250: do not copy port.fifosize member twice
@ 2015-05-07 10:04 Masahiro Yamada
2015-05-07 10:12 ` Peter Hurley
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2015-05-07 10:04 UTC (permalink / raw)
To: linux-serial
Cc: Masahiro Yamada, Sebastian Andrzej Siewior, Jiri Slaby,
Peter Hurley, Alan Cox, Andy Shevchenko, linux-kernel,
Ricardo Ribalda Delgado, Tony Lindgren, Greg Kroah-Hartman,
Yoshihiro YUNOMAE
The port.fifosize member has already been copied at 8 lines above.
Maybe the compiler optimization can clean it away, but just in case.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/tty/serial/8250/8250_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 4506e40..4882027 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -3850,7 +3850,6 @@ int serial8250_register_8250_port(struct uart_8250_port *up)
uart->port.mapbase = up->port.mapbase;
uart->port.mapsize = up->port.mapsize;
uart->port.private_data = up->port.private_data;
- uart->port.fifosize = up->port.fifosize;
uart->tx_loadsz = up->tx_loadsz;
uart->capabilities = up->capabilities;
uart->port.throttle = up->port.throttle;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: 8250: do not copy port.fifosize member twice
2015-05-07 10:04 [PATCH] serial: 8250: do not copy port.fifosize member twice Masahiro Yamada
@ 2015-05-07 10:12 ` Peter Hurley
0 siblings, 0 replies; 2+ messages in thread
From: Peter Hurley @ 2015-05-07 10:12 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-serial, Sebastian Andrzej Siewior, Jiri Slaby, Alan Cox,
Andy Shevchenko, linux-kernel, Ricardo Ribalda Delgado,
Tony Lindgren, Greg Kroah-Hartman, Yoshihiro YUNOMAE
On 05/07/2015 06:04 AM, Masahiro Yamada wrote:
> The port.fifosize member has already been copied at 8 lines above.
> Maybe the compiler optimization can clean it away, but just in case.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-07 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 10:04 [PATCH] serial: 8250: do not copy port.fifosize member twice Masahiro Yamada
2015-05-07 10:12 ` Peter Hurley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).