From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Fabio Estevam <festevam@gmail.com>,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jiwang <jiada_wang@mentor.com>, Jiri Slaby <jslaby@suse.cz>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
anton_bondarenko@mentor.com, Dirk Behme <dirk.behme@de.bosch.com>,
Nicolae Rosia <nicolae.rosia@gmail.com>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2] serial: imx: Revert "initialized DMA w/o HW flow enabled"
Date: Fri, 08 May 2015 13:50:47 +0200 [thread overview]
Message-ID: <554CA317.8050303@linutronix.de> (raw)
In-Reply-To: <CAOMZO5Cu1AG7xYN+uCKnueiwBzBVDhXmqX3FkF3u03Faju4thw@mail.gmail.com>
On 05/08/2015 01:30 PM, Fabio Estevam wrote:
> On Fri, May 8, 2015 at 4:13 AM, Sebastian Andrzej Siewior
> <sebastian@breakpoint.cc> wrote:
>
>> +
>> + /*
>> + * Can we enable the DMA support? Be aware that
>> + * at least IMX6 needs to load external SDMA firmware in
>> + * order work properly. The in-ROM firmware is not
>> + * wokring properly.
>> + */
>
> On my tests:
>
> Prior to this patch: with the internal ROM SDMA firmware I got UART
> issues when communicating through a Bluetooth module. With external
> SDMA firmware (version 3.1) it worked fine.
>
> With your patch applied: Bluetooth worked fine even with no external
> SDMA firmware, which does not match the comments you added.
Why doesn't it match the comment? The patch disables DMA so the SDMA
firmware does not matter.
> Can't you just remove these comments?
>
> Thanks
Sebastian
next prev parent reply other threads:[~2015-05-08 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 20:24 [PATCH] serial: imx: Revert "initialized DMA w/o HW flow enabled" Sebastian Andrzej Siewior
2015-05-07 20:54 ` Fabio Estevam
2015-05-07 21:16 ` Sebastian Andrzej Siewior
2015-05-07 22:11 ` Fabio Estevam
2015-05-07 23:17 ` Fabio Estevam
2015-05-08 7:13 ` [PATCH v2] " Sebastian Andrzej Siewior
2015-05-08 11:30 ` Fabio Estevam
2015-05-08 11:50 ` Sebastian Andrzej Siewior [this message]
2015-05-08 12:24 ` Fabio Estevam
2015-05-19 12:18 ` Fabio Estevam
2015-06-12 13:30 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CA317.8050303@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anton_bondarenko@mentor.com \
--cc=dirk.behme@de.bosch.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiada_wang@mentor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nicolae.rosia@gmail.com \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).