From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH v3] serial: 8250_uniphier: add UniPhier serial driver Date: Tue, 19 May 2015 10:57:59 +0200 Message-ID: <555AFB17.1050703@suse.cz> References: <1431997900-18390-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada , Matthias Brugger Cc: Peter Hurley , John Crispin , Tony Lindgren , Greg Kroah-Hartman , Joachim Eastwood , "linux-kernel@vger.kernel.org" , linux-serial@vger.kernel.org, Ricardo Ribalda Delgado , Andy Shevchenko , Sebastian Andrzej Siewior , "linux-arm-kernel@lists.infradead.org" , Alan Cox List-Id: linux-serial@vger.kernel.org On 05/19/2015, 10:54 AM, Masahiro Yamada wrote: >>> +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control Register */ >>> +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register */ >>> +#define UNIPHIER_UART_LCR_SHIFT 8 >>> +#define UNIPHIER_UART_DLR 9 /* Divisor Latch Register */ >> >> Nit pick: Please fix identation. After "define" just put one blank. >> I personally prefer that the define values are aligned by tabs, but >> that's up tu you. >> > > I intentionally use deeper indentation for *_SHIFT > because I want to clearly show UNIPHIER_UART_LCR_SHIFT > belongs to UNIPHIER_UART_LCR_MCR register. > > I also want to describe them within 80 columns including comments, > so I cannot insert extra TABs to align the values. Hi, what about one space between # and define which is used sometimes? -- js suse labs