* [PATCH] serial: samsung: only use earlycon for console
@ 2015-05-19 20:26 Arnd Bergmann
2015-05-26 14:00 ` Peter Hurley
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-05-19 20:26 UTC (permalink / raw)
To: gregkh
Cc: linux-serial, linux-samsung-soc, linux-arm-kernel, peter, tfiga,
Marek Szyprowski, Alim Akhtar, Chanwoo Choi
A configuration that enables earlycon but not the core console
code causes a link error:
drivers/built-in.o: In function `setup_earlycon':
drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
That error can be triggered by the newly added samsung earlycon support,
which is missing a 'select' statement.
As suggested by Peter Hurley, solves the problem by moving the
'select SERIAL_EARLYCON' statement to the samsung console driver
option, as it is done by all other console drivers.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b94ba0328d3b3 ("serial: samsung: Add support for early console")
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 43b61f8e3e74..9adfd0997865 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -241,7 +241,6 @@ config SERIAL_SAMSUNG
tristate "Samsung SoC serial support"
depends on PLAT_SAMSUNG || ARCH_EXYNOS
select SERIAL_CORE
- select SERIAL_EARLYCON
help
Support for the on-chip UARTs on the Samsung S3C24XX series CPUs,
providing /dev/ttySAC0, 1 and 2 (note, some machines may not
@@ -277,6 +276,7 @@ config SERIAL_SAMSUNG_CONSOLE
bool "Support for console on Samsung SoC serial port"
depends on SERIAL_SAMSUNG=y
select SERIAL_CORE_CONSOLE
+ select SERIAL_EARLYCON
help
Allow selection of the S3C24XX on-board serial ports for use as
an virtual console.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: samsung: only use earlycon for console
2015-05-19 20:26 [PATCH] serial: samsung: only use earlycon for console Arnd Bergmann
@ 2015-05-26 14:00 ` Peter Hurley
0 siblings, 0 replies; 2+ messages in thread
From: Peter Hurley @ 2015-05-26 14:00 UTC (permalink / raw)
To: Arnd Bergmann, gregkh
Cc: linux-serial, linux-samsung-soc, linux-arm-kernel, tfiga,
Marek Szyprowski, Alim Akhtar, Chanwoo Choi
On 05/19/2015 04:26 PM, Arnd Bergmann wrote:
> A configuration that enables earlycon but not the core console
> code causes a link error:
>
> drivers/built-in.o: In function `setup_earlycon':
> drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
>
> That error can be triggered by the newly added samsung earlycon support,
> which is missing a 'select' statement.
>
> As suggested by Peter Hurley, solves the problem by moving the
> 'select SERIAL_EARLYCON' statement to the samsung console driver
> option, as it is done by all other console drivers.
Thanks.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-26 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 20:26 [PATCH] serial: samsung: only use earlycon for console Arnd Bergmann
2015-05-26 14:00 ` Peter Hurley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).