* Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' [not found] ` <557ED81D.7090908-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> @ 2015-06-15 13:58 ` Marcel Holtmann [not found] ` <7CF3D545-DAE4-4510-9726-5D40740DDC5D-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Marcel Holtmann @ 2015-06-15 13:58 UTC (permalink / raw) To: Guenter Roeck Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Danis, BlueZ development, linux-serial-u79uwXL29TY76Z2rM5mHXA Hi Guenter, > alpha:allmodconfig fails to build in -next with > > drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': > drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared > > BOTHER is not defined for all architectures and otherwise only > used with '#ifdef BOTHER'. thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <7CF3D545-DAE4-4510-9726-5D40740DDC5D-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>]
* Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' [not found] ` <7CF3D545-DAE4-4510-9726-5D40740DDC5D-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> @ 2015-06-15 14:25 ` Guenter Roeck [not found] ` <557EE045.2090503-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Guenter Roeck @ 2015-06-15 14:25 UTC (permalink / raw) To: Marcel Holtmann Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Danis, BlueZ development, linux-serial-u79uwXL29TY76Z2rM5mHXA On 06/15/2015 06:58 AM, Marcel Holtmann wrote: > Hi Guenter, > >> alpha:allmodconfig fails to build in -next with >> >> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': >> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared >> >> BOTHER is not defined for all architectures and otherwise only >> used with '#ifdef BOTHER'. > > thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. > So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side. However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes. Guenter ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <557EE045.2090503-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>]
* RE: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' [not found] ` <557EE045.2090503-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> @ 2015-06-15 14:38 ` Ilya Faenson 2015-06-15 14:43 ` Marcel Holtmann 0 siblings, 1 reply; 5+ messages in thread From: Ilya Faenson @ 2015-06-15 14:38 UTC (permalink / raw) To: Guenter Roeck, Marcel Holtmann Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Danis, BlueZ development, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi Guenter, -----Original Message----- From: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Guenter Roeck Sent: Monday, June 15, 2015 10:25 AM To: Marcel Holtmann Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Frederic Danis; BlueZ development; linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' On 06/15/2015 06:58 AM, Marcel Holtmann wrote: > Hi Guenter, > >> alpha:allmodconfig fails to build in -next with >> >> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': >> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared >> >> BOTHER is not defined for all architectures and otherwise only >> used with '#ifdef BOTHER'. > > thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. > So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side. However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes. IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion). Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' 2015-06-15 14:38 ` Ilya Faenson @ 2015-06-15 14:43 ` Marcel Holtmann [not found] ` <7F15059F-B180-4722-8167-864C4A24CE9B-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Marcel Holtmann @ 2015-06-15 14:43 UTC (permalink / raw) To: Ilya Faenson Cc: Guenter Roeck, linux-kernel@vger.kernel.org, Frederic Danis, BlueZ development, linux-serial@vger.kernel.org Hi Ilya, >>> alpha:allmodconfig fails to build in -next with >>> >>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': >>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared >>> >>> BOTHER is not defined for all architectures and otherwise only >>> used with '#ifdef BOTHER'. >> >> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. >> > > So far it has been fixed with #ifdef, and this is the first code which > uses it outside drivers/tty. So my first tendency would be to fix it > on the user side. > > However, looking into it, I think only alpha and avr32 are affected. > Let me submit patches against those and see where it goes. > > IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion). can you extract this and just submit that version. We might just take that into hci_ldisc.c right away. However fixing the #ifdef around BOTHER is useful as well since they look unneeded. At least I can not see a reason why a platform would not define them. Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <7F15059F-B180-4722-8167-864C4A24CE9B-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>]
* RE: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' [not found] ` <7F15059F-B180-4722-8167-864C4A24CE9B-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> @ 2015-06-15 16:51 ` Ilya Faenson 0 siblings, 0 replies; 5+ messages in thread From: Ilya Faenson @ 2015-06-15 16:51 UTC (permalink / raw) To: Marcel Holtmann Cc: Guenter Roeck, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Danis, BlueZ development, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi Marcel, -----Original Message----- From: Marcel Holtmann [mailto:marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org] Sent: Monday, June 15, 2015 10:43 AM To: Ilya Faenson Cc: Guenter Roeck; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Frederic Danis; BlueZ development; linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' Hi Ilya, >>> alpha:allmodconfig fails to build in -next with >>> >>> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': >>> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared >>> >>> BOTHER is not defined for all architectures and otherwise only >>> used with '#ifdef BOTHER'. >> >> thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. >> > > So far it has been fixed with #ifdef, and this is the first code which > uses it outside drivers/tty. So my first tendency would be to fix it > on the user side. > > However, looking into it, I think only alpha and avr32 are affected. > Let me submit patches against those and see where it goes. > > IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion). can you extract this and just submit that version. We might just take that into hci_ldisc.c right away. IF: I've published my version now, thanks. However fixing the #ifdef around BOTHER is useful as well since they look unneeded. At least I can not see a reason why a platform would not define them. Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-15 16:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <557ED81D.7090908@roeck-us.net>
[not found] ` <557ED81D.7090908-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-06-15 13:58 ` Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' Marcel Holtmann
[not found] ` <7CF3D545-DAE4-4510-9726-5D40740DDC5D-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2015-06-15 14:25 ` Guenter Roeck
[not found] ` <557EE045.2090503-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-06-15 14:38 ` Ilya Faenson
2015-06-15 14:43 ` Marcel Holtmann
[not found] ` <7F15059F-B180-4722-8167-864C4A24CE9B-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2015-06-15 16:51 ` Ilya Faenson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox