From: Jiri Slaby <jslaby@suse.cz>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Peter Huewe <PeterHuewe@gmx.de>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
peter_hong@fintek.com.tw
Subject: Re: [PATCH v3 4/5] serial/8250_fintek: Support keys different than default
Date: Tue, 16 Jun 2015 10:50:30 +0200 [thread overview]
Message-ID: <557FE356.9040805@suse.cz> (raw)
In-Reply-To: <1434444069-30260-5-git-send-email-ricardo.ribalda@gmail.com>
On 06/16/2015, 10:41 AM, Ricardo Ribalda Delgado wrote:
> @@ -148,20 +148,25 @@ static int fintek_8250_rs485_config(struct uart_port *port,
> return 0;
> }
>
> -static int fintek_8250_base_port(void)
> +static int fintek_8250_base_port(u8 *key)
> {
> static const u16 addr[] = {0x4e, 0x2e};
> - int i;
> + static const u16 keys[] = {0x77, 0xa0, 0x87, 0x67};
Hi, given keys are treated as u8 everywhere, this should be u8 too.
regards,
--
js
suse labs
next prev parent reply other threads:[~2015-06-16 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 8:41 [PATCH v3 0/5] serial/8250_fintek Support any configuration Ricardo Ribalda Delgado
2015-06-16 8:41 ` [PATCH v3 1/5] serial/8250_fintek: Use private data structure Ricardo Ribalda Delgado
2015-06-16 8:41 ` [PATCH v3 2/5] serial/8250_fintek: Support for multiple base_ports Ricardo Ribalda Delgado
2015-06-16 8:41 ` [PATCH v3 3/5] serial/8250_fintek: Support for chip_ip 0x0501 Ricardo Ribalda Delgado
2015-06-16 8:41 ` [PATCH v3 4/5] serial/8250_fintek: Support keys different than default Ricardo Ribalda Delgado
2015-06-16 8:50 ` Jiri Slaby [this message]
2015-06-16 8:41 ` [PATCH v3 5/5] serial/8250_fintek: Support for any io address Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557FE356.9040805@suse.cz \
--to=jslaby@suse.cz \
--cc=PeterHuewe@gmx.de \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=rafael.j.wysocki@intel.com \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).