From: Niklas Cassel <niklas.cassel@axis.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Niklas Cassel <niklass@axis.com>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Jiri Slaby" <jslaby@suse.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"Jesper Nilsson" <jespern@axis.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API
Date: Mon, 27 Jul 2015 15:29:37 +0200 [thread overview]
Message-ID: <55B63241.7080409@axis.com> (raw)
In-Reply-To: <CACRpkdZce3Jfh3Mz0mW=XS72UUD5RP5okocLs_--N1B2aLNJDA@mail.gmail.com>
On 07/27/2015 03:16 PM, Linus Walleij wrote:
> On Fri, Jul 24, 2015 at 12:23 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> On Tue, Jul 21, 2015 at 01:34:52PM -0700, Guenter Roeck wrote:
>>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>>> makes the flags argument to devm_gpiod_get_optional mandatory but does not
>>> update all users. This results in the following build error.
>>>
>>> drivers/tty/serial/etraxfs-uart.c:933:16: error:
>>> too few arguments to function ‘devm_gpiod_get_optional’
>>>
>>> Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>>
>> This patch isn't in Linus's tree, so whatever tree this commit is in,
>> needs to also take this fix.
>
> OK I'll take it. It's a bit messy with this breakage but it is for
> a good cause.
>
> Niklas: send me your patch when finished.
I've already sent them to the linux-serial and linux-kernel mailing lists.
I'm sorry that I didn't think of CC:ing you Linus.
It might be better if you take them, since you got
the devm_gpiod_get_optional patches in your tree.
http://marc.info/?l=linux-serial&m=143778406314867
http://marc.info/?l=linux-serial&m=143778407714871
next prev parent reply other threads:[~2015-07-27 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 20:34 [PATCH -next] serial: etraxfs-uart: Update gpiod API Guenter Roeck
2015-07-21 21:01 ` Uwe Kleine-König
2015-07-21 22:17 ` Guenter Roeck
2015-07-22 7:06 ` Uwe Kleine-König
2015-07-22 14:51 ` Guenter Roeck
2015-07-22 15:31 ` Niklas Cassel
2015-07-23 22:23 ` Greg Kroah-Hartman
2015-07-24 6:33 ` Uwe Kleine-König
2015-07-27 13:16 ` Linus Walleij
2015-07-27 13:29 ` Niklas Cassel [this message]
2015-07-27 13:59 ` Uwe Kleine-König
2015-07-27 14:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B63241.7080409@axis.com \
--to=niklas.cassel@axis.com \
--cc=gregkh@linuxfoundation.org \
--cc=jespern@axis.com \
--cc=jslaby@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=niklass@axis.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).