From: Peter Hurley <peter@hurleysoftware.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
"Anirudha Sarangi" <anirudha.sarangi@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Jiri Slaby" <jslaby@suse.com>,
linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd parity
Date: Mon, 17 Aug 2015 11:39:03 -0400 [thread overview]
Message-ID: <55D20017.4010008@hurleysoftware.com> (raw)
In-Reply-To: <5b154ba97bcd79e49e2131152eb2fc1761594a6c.1439796149.git.michal.simek@xilinx.com>
On 08/17/2015 03:22 AM, Michal Simek wrote:
> From: Anirudha Sarangi <anirudha.sarangi@xilinx.com>
>
> Existing set_termios does not handle the option for enabling
> odd parity. This patch fixes it.
NAK. PARODD does not enable parity generation or detection.
Regards,
Peter Hurley
> Signed-off-by: Anirudha Sarangi <anirudh@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/tty/serial/xilinx_uartps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 009e0dbc12d2..a3020344ac9d 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -723,7 +723,7 @@ static void cdns_uart_set_termios(struct uart_port *port,
> else
> cval |= CDNS_UART_MR_STOPMODE_1_BIT; /* 1 STOP bit */
>
> - if (termios->c_cflag & PARENB) {
> + if ((termios->c_cflag & PARENB) || (termios->c_cflag & PARODD)) {
> /* Mark or Space parity */
> if (termios->c_cflag & CMSPAR) {
> if (termios->c_cflag & PARODD)
>
next prev parent reply other threads:[~2015-08-17 15:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 7:22 [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd parity Michal Simek
2015-08-17 7:22 ` [PATCH 2/4] serial: xuartps: Do not handle overrun errors under IGNPAR option Michal Simek
2015-08-17 15:49 ` Peter Hurley
2015-08-17 15:58 ` Anirudha Sarangi
2015-08-17 16:19 ` Peter Hurley
2015-08-17 18:07 ` Anirudha Sarangi
2015-08-17 7:22 ` [PATCH 3/4] serial: xuartps: Do not enable parity error interrupt Michal Simek
2015-08-17 7:22 ` [PATCH 4/4] serial: xuartps: Rewrite the interrupt handling logic Michal Simek
2015-08-17 15:55 ` Peter Hurley
2015-08-17 16:00 ` Anirudha Sarangi
2015-08-17 18:46 ` Peter Hurley
2015-08-17 15:39 ` Peter Hurley [this message]
2015-08-17 15:55 ` [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd parity Anirudha Sarangi
2015-08-17 16:24 ` Peter Hurley
2015-08-17 18:06 ` Anirudha Sarangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D20017.4010008@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=anirudha.sarangi@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox