linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	Julia Lawall <julia.lawall@lip6.fr>
Cc: Alessandro Rubini <rubini@gnudd.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	David Woodhouse <dwmw2@infradead.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jie Yang <yang.jie@intel.com>, Jiri Slaby <jslaby@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Kay Sievers <kay@vrfy.org>, Kevin Cernekee <cernekee@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Michal Marek <mmarek@suse.com>, Ming Lei <ming.lei@canonical.com>,
	Takashi Iwai <tiwai@suse.de>, Tom Gundersen <teg@jklm.no>,
	Yalin Wang <yalin.wang2010@gmail.com>,
	Coccinelle <cocci@systeme.lip6.fr>,
	linux-doc@vger.kernel.org, linux-serial@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Cocci] [RFC] firmware: annotate thou shalt not request fw on init or probe
Date: Thu, 3 Sep 2015 13:45:50 +0200	[thread overview]
Message-ID: <55E832EE.7050801@users.sourceforge.net> (raw)
In-Reply-To: <1440811107-861-1-git-send-email-mcgrof@do-not-panic.com>

> +@ calls_fw_on_init depends on defines_module_init @
> +identifier defines_module_init.init;
> +position p1;
> +@@
> +
> +init(void)
> +{
> + ...

Would it make sense to use the specification "when any"
for such a SmPL ellipsis?
http://coccinelle.lip6.fr/docs/main_grammar004.html


> +(
> +request_firmware@p1(...)
> +|
> +request_firmware_nowait@p1(...)
> +|
> +request_firmware_direct@p1(...)
> +)
> +...
> +}


Are there any more source code variants to check today?

Regards,
Markus

      parent reply	other threads:[~2015-09-03 11:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-29  1:18 [RFC] firmware: annotate thou shalt not request fw on init or probe Luis R. Rodriguez
2015-08-29 16:18 ` Julia Lawall
2015-09-03  1:35   ` Luis R. Rodriguez
2015-09-03  5:56     ` Julia Lawall
2016-06-16 20:56       ` Luis R. Rodriguez
2015-09-01 17:28 ` Josh Boyer
2015-09-03  1:37   ` Luis R. Rodriguez
2015-09-03 11:45 ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E832EE.7050801@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=cernekee@gmail.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=corbet@lwn.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jslaby@suse.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kay@vrfy.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mcgrof@do-not-panic.com \
    --cc=ming.lei@canonical.com \
    --cc=mmarek@suse.com \
    --cc=rubini@gnudd.com \
    --cc=teg@jklm.no \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yalin.wang2010@gmail.com \
    --cc=yang.jie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).