From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ED1B1BF7ED for ; Tue, 27 Aug 2024 14:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724767506; cv=none; b=cqiFU8Gs3BoCk5ileCTMD22dgWLgKi5eyxzuoLBBDq+O+wD5mTj0v2MUi+ZwBQcbRQKvoeRjF2QdSl11/AsUeaZg5QfSXldk4CIoD3MMAO61RrFA374MHiBwCXlzco8J5aQJMILhsW9drJ6oEFXGHWkVqLvpaJdMFh8jdpeFAa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724767506; c=relaxed/simple; bh=bM4fxNbrY/+xVU8fyQSBkQzkgoPZsh5qN3u1v0lkPNQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uVX4zAJ3dVXOpZZeeTpoIZwCbx/cPpqB+DZhDDoJNNzHYZYaCzhbE0/Xb27DX/kR59ydZJ+CT34EIn4gw3NpFMOfpP1OXEgmf2KsXuX9HYFBZafvn+z2mMsUiKba+FyFKCcplPzk3IWZRq/jF5Z/6TA6qp3T14ijikRgxDUcxUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RCvrLB02; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RCvrLB02" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724767504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o/+4z3eCYQ3ifiWxh2Mo64fSEyLTY0srxIMSGlgXIu0=; b=RCvrLB02miXAzHsvPV4RIlvMwKHejFSNlYMCPkmQ4xdhmTC3J6ggZgfTi7ZzIx8Lw/jmuL AfkSSGz0lc+imyDV1RI+2fzsLAbVJuh70ODnHt4KUsYs+2RBhk6IYDLcT6YMEp7MLF3B7D he8dQAzk8MQCEwz4Cp5zjTEIzCXrdHU= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-2Sua-kp7NoGBws4wErbnnQ-1; Tue, 27 Aug 2024 10:05:03 -0400 X-MC-Unique: 2Sua-kp7NoGBws4wErbnnQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a867bc4f3c4so878448566b.0 for ; Tue, 27 Aug 2024 07:05:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724767502; x=1725372302; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o/+4z3eCYQ3ifiWxh2Mo64fSEyLTY0srxIMSGlgXIu0=; b=JIY75qhk9Hln8jfBpm98xPUtN8H5Tx8iKW3lTmP51zORu+6k0HNY4UIGL6lPHgxYSD gPUuHl2gazScW077wDmcMMwA3ksP1O//0sYEMM+u2UKhvIo5X/xSOs37jNNzNTAx1iRq USi0vNs5VF8BR9lVSUvDtJivOrmpiLNSeNaIdFQdSvmWhAB3AQtH46z4kscHj7dODWn1 JZh1vtckborgzvu7z4dVQ+7SOEZPWMhli3g7cWT1Y/jnLXOIgN9FZnrrw1kF7jLYgZ2D 0EsVkGhvAl1Wp1CHC+iNS4NhkeMZkfpt44Cz7b2FAhxcK4lMs4ZbDWnVsN1jc7i8oJlZ CsBg== X-Forwarded-Encrypted: i=1; AJvYcCWB9Q8UfetSkcGB0eBZok7svsiIKAmw+6eLXkGx5KlY7dxl5QAOte855YHtfLrkScy+ytNiFDvGkmHaJow=@vger.kernel.org X-Gm-Message-State: AOJu0YxIw4atbY2DlN9Xe5d8kYi2ezjbfIRsVDUjvudGF4IcmM3n+ou3 PXhBK5n3OsgnDDW4SlwyzwNKJxOBUCFs8kySoSYbPEeauwSKUMGzHOB/+IyTKyrXbR0PXQrNGsl kq3hY22OfB9RWtwU02K/F0J3r8+0G1xzPWt5OtIL8Zlv2D3HYMhPSWxImYevX2A== X-Received: by 2002:a17:906:fe46:b0:a7a:130e:fb6e with SMTP id a640c23a62f3a-a86e297a558mr332226366b.15.1724767501475; Tue, 27 Aug 2024 07:05:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPFM6fsuNqAoz9t1ZCb79CqPD0sS5dxWyKrPwS3nP6u25sZDYw8Fpsre6BrGY9O9j4ICI+Jw== X-Received: by 2002:a17:906:fe46:b0:a7a:130e:fb6e with SMTP id a640c23a62f3a-a86e297a558mr332217866b.15.1724767500740; Tue, 27 Aug 2024 07:05:00 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a86e582d54dsm112656866b.129.2024.08.27.07.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 07:05:00 -0700 (PDT) Message-ID: <56292842-2071-4c26-a380-c6ae1488361a@redhat.com> Date: Tue, 27 Aug 2024 16:04:58 +0200 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] platform/surface: Add OF support To: Konrad Dybcio , Andy Shevchenko Cc: Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Len Brown , Maximilian Luz , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Marijn Suijten , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bjorn Andersson , Konrad Dybcio References: <20240814-topic-sam-v3-0-a84588aad233@quicinc.com> <20240814-topic-sam-v3-3-a84588aad233@quicinc.com> <4dab4f36-309d-4b95-8b01-84963ca08d16@redhat.com> From: Hans de Goede In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 8/27/24 3:52 PM, Konrad Dybcio wrote: > On 27.08.2024 11:07 AM, Hans de Goede wrote: >> Hi Andy, >> >> Thank you for the review. >> >> Note this has already been merged though. >> >> Still there are some good suggestions here for a follow-up >> cleanup patch. > > Andy, Hans > > Is it fine if I submit a fat "address review comments" patch, or should > I split it up per issue? I would say use your best judgement / something in the middle. IOW start with a fat "address review comments" patch and if specific parts turn out to be somewhat involved do 1 patch with smaller clean-ups and split out the involved parts in a separate patch. Thanks & Regards, Hans