From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] Revert "serial: amba-pl011: fix incorrect integer size in pl011_fifo_to_tty()" Date: Fri, 23 Oct 2015 10:37:49 -0500 Message-ID: <562A544D.7080506@tabi.org> References: <1445594400-29095-1-git-send-email-shijie.huang@arm.com> <20151023103056.GI4801@e103592.cambridge.arm.com> <562A297A.9030204@codeaurora.org> <20151023133403.GI4796@e103592.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151023133403.GI4796@e103592.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dave P Martin Cc: Huang Shijie , gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On 10/23/2015 08:34 AM, Dave P Martin wrote: > Well, I'm not saying there's definitely no kernel bug, but I can't see > how the patch should cause it. It may be triggering a latent bug > somewhere else in the driver than hasn't been biting us before, however. Fair enough. > !CREAD is the most obvious cause, so that should definitely be ruled > out first. If CREAD is clear, we need to figure out why... So I tested this by booting to my console, and then typing in: stty -cread and when I did that, the console ignored all input. I do admit that since !CREAD has been ignored for so many reason, it could be that a lot of userspaces will suddenly have broken consoles.