From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v13 5/5] uart: pl011: Add support to ZTE ZX296702 uart Date: Mon, 26 Oct 2015 07:46:42 -0500 Message-ID: <562E20B2.4050805@codeaurora.org> References: <1438328959-16177-1-git-send-email-jun.nie@linaro.org> <1438328959-16177-6-git-send-email-jun.nie@linaro.org> <55FC16A2.5070207@arm.com> <562AFBD5.3050508@codeaurora.org> <562DF96D.6020307@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <562DF96D.6020307@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andre Przywara , Jun Nie Cc: "linux@arm.linux.org.uk" , "peter@hurleysoftware.com" , "jason.liu@linaro.org" , "gregkh@linuxfoundation.org" , Andrew Jackson , "linux-serial@vger.kernel.org" , "shawn.guo@linaro.org" , "wan.zhijun@zte.com.cn" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-serial@vger.kernel.org Andre Przywara wrote: > I tried to refactor the driver lately to split up SBSA and PL011 support > and got something that compiles, though I wasn't fully satisfied and I > ran out of time. The refactor idea was to split driver runtime from > initialization, so the different probe and init functions can be moved > into separate files. There would be one stub file with all the core > driver logic (DMA, IRQ handling, buffer handling, communication > parameters setup) and one file for each subtype (PL011, SBSA, ZTE, you > name it). > If people are interested, I can try to clean this up and post it as an RFC. I am interested. We need support for subtype 13, because our hardware only supports 32-bit access to all registers. We have an internal patch that replaces all of the read/write routines with vendor function calls. I would need to refactor our patch on top of yours. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.