From: Peter Hurley <peter@hurleysoftware.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-serial@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Rob Herring <robh@kernel.org>,
Kevin Cernekee <cernekee@gmail.com>,
linux-api@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3] serial: support 16-bit register interface for console
Date: Tue, 27 Oct 2015 09:53:02 -0400 [thread overview]
Message-ID: <562F81BE.3000502@hurleysoftware.com> (raw)
In-Reply-To: <1445832662-23250-1-git-send-email-yamada.masahiro@socionext.com>
Hi Masahiro,
On 10/26/2015 12:11 AM, Masahiro Yamada wrote:
> Currently, 8-bit (MMIO) and 32-bit (MMIO32) register interfaces are
> supported for the 8250 console, but the 16-bit (MMIO16) is not.
> The 8250 UART device on my board is connected to a 16-bit bus
> and my main motivation is to use earlycon with it.
> (Refer to arch/arm/boot/dts/uniphier-support-card.dtsi)
As I noted in reviewing v2, the patch hunk below does not apply.
You must rebase your changes on top of Greg's tty-next tree.
Regards,
Peter Hurley
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 603d2cc..325acce 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1819,8 +1819,8 @@ uart_get_console(struct uart_port *ports, int nr, struct console *co)
> * @options: ptr for <options> field; NULL if not present (out)
> *
> * Decodes earlycon kernel command line parameters of the form
> - * earlycon=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> - * console=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> + * earlycon=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
> + * console=<name>,io|mmio|mmio16|mmio32|mmio32be,<addr>,<options>
> *
> * The optional form
> * earlycon=<name>,0x<addr>,<options>
next prev parent reply other threads:[~2015-10-27 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 4:11 [PATCH v3] serial: support 16-bit register interface for console Masahiro Yamada
2015-10-27 13:53 ` Peter Hurley [this message]
[not found] ` <562F81BE.3000502-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-10-28 3:29 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F81BE.3000502@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=bigeasy@linutronix.de \
--cc=cernekee@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).