From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes Date: Tue, 27 Oct 2015 14:24:13 -0400 Message-ID: <562FC14D.6060404@hurleysoftware.com> References: <1445968007-12616-1-git-send-email-dvlasenk@redhat.com> <1445968007-12616-5-git-send-email-dvlasenk@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1445968007-12616-5-git-send-email-dvlasenk@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Denys Vlasenko Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org On 10/27/2015 01:46 PM, Denys Vlasenko wrote: > This function compiles to 172 bytes of machine code. > > Signed-off-by: Denys Vlasenko > CC: Greg Kroah-Hartman > CC: Peter Hurley > CC: Jiri Slaby > CC: linux-serial@vger.kernel.org > --- > drivers/tty/serial/fsl_lpuart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > index 08ce76f..ac26303 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -527,7 +527,7 @@ static inline void lpuart_prepare_rx(struct lpuart_port *sport) > spin_unlock_irqrestore(&sport->port.lock, flags); > } > > -static inline void lpuart_transmit_buffer(struct lpuart_port *sport) > +static void lpuart_transmit_buffer(struct lpuart_port *sport) > { > struct circ_buf *xmit = &sport->port.state->xmit; You'll want to run your script(s) on Greg's tty-next tree; this file has copy+paste changes for 4.4 that added lpuart32_transmit_buffer() as an inline function. Regards, Peter Hurley