From: Peter Hurley <peter@hurleysoftware.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes
Date: Tue, 27 Oct 2015 14:55:22 -0400 [thread overview]
Message-ID: <562FC89A.50703@hurleysoftware.com> (raw)
In-Reply-To: <1445968007-12616-7-git-send-email-dvlasenk@redhat.com>
On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 98 bytes of machine code.
This looks ok because these function are heavyweight.
You'll want to add men_z135_reg_set() to this patch
as well, and please cc the driver author:
Johannes Thumshirn <johannes.thumshirn@men.de>
Regards,
Peter Hurley
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Peter Hurley <peter@hurleysoftware.com>
> CC: Jiri Slaby <jslaby@suse.com>
> CC: linux-serial@vger.kernel.org
> ---
> drivers/tty/serial/men_z135_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
> index b90e7b3..2b5b66f 100644
> --- a/drivers/tty/serial/men_z135_uart.c
> +++ b/drivers/tty/serial/men_z135_uart.c
> @@ -159,7 +159,7 @@ static inline void men_z135_reg_set(struct men_z135_port *uart,
> * @addr: Register address
> * @val: value to clear
> */
> -static inline void men_z135_reg_clr(struct men_z135_port *uart,
> +static void men_z135_reg_clr(struct men_z135_port *uart,
> u32 addr, u32 val)
> {
> struct uart_port *port = &uart->port;
>
next prev parent reply other threads:[~2015-10-27 18:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 17:46 [PATCH 00/15] drivers/tty/: Deinline smaller/less used functions Denys Vlasenko
2015-10-27 17:46 ` [PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes Denys Vlasenko
2015-10-27 18:18 ` Peter Hurley
2015-10-27 17:46 ` [PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes Denys Vlasenko
2015-10-27 18:19 ` Peter Hurley
2015-10-27 17:46 ` [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224 bytes Denys Vlasenko
2015-10-27 18:08 ` Peter Hurley
2015-10-27 17:46 ` [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes Denys Vlasenko
2015-10-27 18:24 ` Peter Hurley
2015-10-27 17:46 ` [PATCH 05/15] serial/m32r_sio: Deinline wait_for_xmitr, save 165 bytes Denys Vlasenko
2015-10-27 18:25 ` Peter Hurley
2015-10-27 17:46 ` [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes Denys Vlasenko
2015-10-27 18:55 ` Peter Hurley [this message]
2015-10-27 17:46 ` [PATCH 07/15] serial/msm_serial: Deinline wait_for_xmitr, save 165 bytes Denys Vlasenko
2015-10-27 18:30 ` Peter Hurley
2015-10-27 17:46 ` [PATCH 08/15] serial/omap-serial: " Denys Vlasenko
2015-10-27 18:31 ` Peter Hurley
2015-10-27 17:46 ` [PATCH 09/15] serial/pxa: " Denys Vlasenko
2015-10-27 18:32 ` Peter Hurley
2015-10-27 18:14 ` [PATCH 00/15] drivers/tty/: Deinline smaller/less used functions Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562FC89A.50703@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=dvlasenk@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).