From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH DRAFT 1/2] drivers: serial: PL011: refactor register access Date: Mon, 2 Nov 2015 07:44:26 -0600 Message-ID: <563768BA.8080109@codeaurora.org> References: <1446467042-24494-1-git-send-email-andre.przywara@arm.com> <1446467042-24494-2-git-send-email-andre.przywara@arm.com> <563764B7.6040202@codeaurora.org> <563767C9.7050206@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <563767C9.7050206@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andre Przywara , Jun Nie , Peter Hurley Cc: Andrew.Jackson@arm.com, Russell King , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org Andre Przywara wrote: > This patch doesn't, I was just enumerating possible extensions which > will become much easier now that we don't have to patch every single > call site for such a change (to give rationale for this refactoring). > Changing the access width is now a simple change in those two functions, > and since you have the struct uart_amba_port available, you can access > any field in there to determine your desired access width. > > As it says on the tin: it's a draft. Feel free to extend it to a proper > series;-) Actually, we already have a patch that does just that, so I'll post it. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.