From mboxrd@z Thu Jan 1 00:00:00 1970 From: Niklas Cassel Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash Date: Mon, 2 Nov 2015 22:13:25 +0100 Message-ID: <5637D1F5.2090608@flawful.org> References: <1446431576-4385-1-git-send-email-linux@roeck-us.net> <20151102073755.GN4931@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151102073755.GN4931@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Guenter Roeck Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org On 11/02/2015 08:37 AM, Uwe Kleine-K=C3=B6nig wrote: >> The function call in the etraxfs-uart driver was not renamed, >> possibly due to interference with commit 7b9c5162c182 ("serial: >> etraxfs-uart: use mctrl_gpio helpers for handling modem signals"). > Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handl= ing > is missing. The only drivers including serial_mctrl_gpio.h is atmel_serial.c, clps711x.c, mxs-auart.c and etraxfs-uart.c etraxfs commit 7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for handlin= g modem signals") is heavily influenced by 62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handling mo= dem signals") a driver which also appears to lack mctrl irq setup/handling. Uwe, are you going to convert all serial drivers that includes serial_m= ctrl_gpio.h to use the new mctrl_gpio_init? (which also sets up irqs) Since mctrl gpios are optional in the device tree, I guess mctrl_gpio_i= nit handles if they are missing. So even if etraxfs-uart.c currently lacks mctrl irq s= etup/handling, if we migrate it to use the new mctrl_gpio_init, we will get this autom= atically?