From: Peter Hurley <peter@hurleysoftware.com>
To: Timur Tabi <timur@codeaurora.org>
Cc: andre.przywara@arm.com, Linus Walleij <linus.walleij@linaro.org>,
Andrew.Jackson@arm.com, rmk+kernel@arm.linux.org.uk,
jun.nie@linaro.or, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <greg@kroah.com>,
jslaby@suse.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access
Date: Thu, 5 Nov 2015 21:44:25 -0500 [thread overview]
Message-ID: <563C1409.4070804@hurleysoftware.com> (raw)
In-Reply-To: <563C09BB.9030706@codeaurora.org>
On 11/05/2015 09:00 PM, Timur Tabi wrote:
> Peter Hurley wrote:
>> Perhaps I wasn't clear enough in my previous comments regarding this
>> approach; I see no benefit to re-using the pl011 earlycon definition.
>> Just define a completely new earlycon for sbsa32 (and zte):
>>
>> EARLYCON_DECLARE(sbsa32, sbsa32_early_console_setup);
>>
>> Example:
>> earlycon=sbsa32,0x3ced1000
>
> Sounds like six of one, half-dozen of another. But I'm happy to modify my patch accordingly. It will avoid the strcmp, but I'm not sure it will reduce the actual number of lines of code.
Or better yet, for sbsa32 earlycon, just use the existing port type constructs.
So,
earlycon=pl011,mmio32,0x3ced1000
which will set port->iotype to UPIO_MEM32, which in turn can be used to select
the correct i/o width in pl011_putc().
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-11-06 2:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 0:37 [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access Timur Tabi
2015-11-06 1:52 ` Peter Hurley
2015-11-06 2:00 ` Timur Tabi
2015-11-06 2:44 ` Peter Hurley [this message]
2015-11-06 18:59 ` Timur Tabi
2015-11-07 22:36 ` Peter Hurley
2015-11-07 23:02 ` Russell King - ARM Linux
2015-11-07 23:31 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563C1409.4070804@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=greg@kroah.com \
--cc=jslaby@suse.com \
--cc=jun.nie@linaro.or \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).