From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH -next] serial: etraxfs-uart: Fix crash Date: Sun, 15 Nov 2015 16:42:40 -0800 Message-ID: <56492680.5040208@roeck-us.net> References: <1446431576-4385-1-git-send-email-linux@roeck-us.net> <20151102073755.GN4931@pengutronix.de> <5637D1F5.2090608@flawful.org> <20151102212933.GB4931@pengutronix.de> <56491B2F.30300@flawful.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <56491B2F.30300@flawful.org> Sender: linux-kernel-owner@vger.kernel.org To: Niklas Cassel , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org On 11/15/2015 03:54 PM, Niklas Cassel wrote: > I think that Guenter's patch should be merged asap. > Right now the bug it fixes stops us from boot testing in qemu. > I'll send out a build (failure) report after -rc1 is out. Maybe that will create enough visibility to get the patch accepted (or officially Nacked). Guenter > For the broken mctrl irq handling part, when Uwe > has converted mxs-auart to use the generic irq init, > I can do the same for etraxfs + make sure that it gets tested > properly on real hardware. > > On 11/02/2015 10:29 PM, Uwe Kleine-K=C3=B6nig wrote: >> Helo Niklas, >> >> On Mon, Nov 02, 2015 at 10:13:25PM +0100, Niklas Cassel wrote: >>> On 11/02/2015 08:37 AM, Uwe Kleine-K=C3=B6nig wrote: >>>>> The function call in the etraxfs-uart driver was not renamed, >>>>> possibly due to interference with commit 7b9c5162c182 ("serial: >>>>> etraxfs-uart: use mctrl_gpio helpers for handling modem signals")= =2E >>>> Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt ha= ndling >>>> is missing. >>> The only drivers including serial_mctrl_gpio.h is atmel_serial.c, >>> clps711x.c, mxs-auart.c and etraxfs-uart.c >>> >>> etraxfs commit >>> 7b9c5162c182 ("serial: etraxfs-uart: use mctrl_gpio helpers for han= dling modem signals") >>> is heavily influenced by >>> 62b0a1b3e759 ("serial: clps711x: Use mctrl_gpio helpers for handlin= g modem signals") >>> >>> a driver which also appears to lack mctrl irq setup/handling. >>> >>> >>> Uwe, are you going to convert all serial drivers that includes seri= al_mctrl_gpio.h to >>> use the new mctrl_gpio_init? (which also sets up irqs) >> That is the plan. For drivers like mxs-auart (that do irq handling) = this >> is just simplification. When the irq handling is missing converting = to >> the new mctrl_gpio_init might introduce regressions because it does >> request_irq which might fail. >> >>> Since mctrl gpios are optional in the device tree, I guess mctrl_gp= io_init handles if >>> they are missing. So even if etraxfs-uart.c currently lacks mctrl i= rq setup/handling, >>> if we migrate it to use the new mctrl_gpio_init, we will get this a= utomatically? >> Right, if there are no gpios specified (new and old) mctrl_gpio is a >> nop. >> >> Best regards >> Uwe >> > >