From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Frias <sf84@laposte.net>
Subject: Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM
Date: Fri, 18 Dec 2015 17:35:33 +0100
Message-ID: <567435D5.2040605@laposte.net>
References: <5672D89A.4090307@laposte.net> <yw1xoadpcbbn.fsf@unicorn.mansr.com> <5672F9C9.1010601@laposte.net> <5673E3FD.8080001@laposte.net> <56742F23.5010501@hurleysoftware.com> <56743405.8020408@laposte.net> <56743584.50500@hurleysoftware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <56743584.50500@hurleysoftware.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, =?UTF-8?B?TcOlbnMgUnU=?= =?UTF-8?B?bGxnw6VyZA==?= <mans@mansr.com>, linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>, Jon Anders Haugum <jonah@omegav.ntnu.no>
List-Id: linux-serial@vger.kernel.org

On 12/18/2015 05:34 PM, Peter Hurley wrote:
> On 12/18/2015 08:27 AM, Sebastian Frias wrote:
>> On 12/18/2015 05:06 PM, Peter Hurley wrote:
>>>> -    unsigned char old_dll, old_dlm, old_lcr;
>>>> +    unsigned char old_lcr;
>>>>        unsigned int id;
>>>> +    unsigned int old_dl;
>>>
>>>      unsigned int id, old_dl;
>>
>> Ok, thanks for your comments.
>> By the way, should I just do:
>>
>> -    unsigned char old_dll, old_dlm, old_lcr;
>> +    unsigned char old_lcr, old_dl;
>>
>> ?
>
> The divisor is a 16-bit value.
>

You are right, I was too eager to "reduce the amount of lines that 
change"...