linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Fuzzey <mfuzzey@parkeon.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Sascha Hauer <kernel@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] serial: imx: Fix suspend / resume.
Date: Fri, 8 Jan 2016 12:13:33 +0100	[thread overview]
Message-ID: <568F99DD.50809@parkeon.com> (raw)
In-Reply-To: <CAOMZO5ADYomDf5EbGAAPJSjEQFOfKi_r7j+xytSuQA5dQh=V0Q@mail.gmail.com>

On 08/01/16 00:51, Fabio Estevam wrote:
> On Thu, Jan 7, 2016 at 9:17 PM, Fabio Estevam <festevam@gmail.com> wrote:
>
>> [   39.487313] [<c05844d0>] (snd_soc_suspend) from [<c03c31f0>]
> Ok, in this case it is an ALSA issue, so will start a thread at the
> alsa mailing list.
Ah,

Just seen I have this in my tree for that:

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index a1305f8..a7ddf69 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -584,6 +584,9 @@ int snd_soc_suspend(struct device *dev)
         if (!card->instantiated)
                 return 0;

+       if (!card->snd_card)
+               return 0;
+
         /* Due to the resume being scheduled into a workqueue we could
         * suspend before that's finished - wait for it to complete.
          */
@@ -814,6 +817,9 @@ int snd_soc_resume(struct device *dev)
         if (!card->instantiated)
                 return 0;

+       if (!card->snd_card)
+               return 0;
+
         /* activate pins from sleep state */



I have that in my old 3.19 tree too so it's not new.

I didn't submit it because I haven't investigated further to see if it 
was just papering over the real problem..

Martin

  reply	other threads:[~2016-01-08 11:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 15:53 [PATCH V2] serial: imx: Fix suspend / resume Martin Fuzzey
2016-01-07 23:17 ` Fabio Estevam
2016-01-07 23:51   ` Fabio Estevam
2016-01-08 11:13     ` Martin Fuzzey [this message]
2016-01-11 20:24       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568F99DD.50809@parkeon.com \
    --to=mfuzzey@parkeon.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).