From: Peter Hurley <peter@hurleysoftware.com>
To: John Ogness <john.ogness@linutronix.de>, gregkh@linuxfoundation.org
Cc: vinod.koul@intel.com, dan.j.williams@intel.com,
bigeasy@linutronix.de, tony@atomide.com, nsekhar@ti.com,
peter.ujfalusi@ti.com, dmaengine@vger.kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] tty: serial: 8250: add optional spinlock arg to serial8250_rx_chars
Date: Fri, 22 Jan 2016 08:18:53 -0800 [thread overview]
Message-ID: <56A2566D.6010408@hurleysoftware.com> (raw)
In-Reply-To: <877fj1rjs0.fsf@linutronix.de>
Hi John,
On 01/22/2016 02:27 AM, John Ogness wrote:
> serial8250_rx_chars() must be called from interrupt context and with
> the port lock held. The port lock is released temporarily within that
> function to call tty_flip_buffer_push(). However, there may be other
> drivers that need to synchronize the tty_flip_buffer_push() call within
> serial8250_rx_chars() with other contexts. Since the port lock cannot
> be used for this synchronization, an optional spinlock argument is added.
> If non-NULL, this will be locked during the tty_flip_buffer_push() call.
I removed the port lock drop-claim in serial8250_rx_chars in patch
"serial: 8250: Remove low_latency workaround" (Greg has this patch in his
inbox but not in next because of the merge window).
IOW, you can drop this patch.
Regards,
Peter Hurley
prev parent reply other threads:[~2016-01-22 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 10:27 [PATCH 2/4] tty: serial: 8250: add optional spinlock arg to serial8250_rx_chars John Ogness
2016-01-22 16:18 ` Peter Hurley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A2566D.6010408@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=bigeasy@linutronix.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).