From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aleksey Makarov Subject: Re: [PATCH 1/3] printk: make preferred_console local static bool Date: Mon, 25 Jan 2016 18:51:59 +0600 Message-ID: <56A61A6F.10409@linaro.org> References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-2-git-send-email-aleksey.makarov@linaro.org> <1453725901.28952.53.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453725901.28952.53.camel@perches.com> Sender: linux-acpi-owner@vger.kernel.org To: Joe Perches , linux-acpi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Graeme Gregory , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm List-Id: linux-serial@vger.kernel.org On 25.01.2016 18:45, Joe Perches wrote: > On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote: >> The variable preferred_console is used only inside register_console() >> and it's semantics is boolean. Make it clear. > > This loses the index of the preferred console. > I'm not sure this is better. That index is not used anywhere. I believe the patch makes things clear. Also, it indexes the array console_cmdline. With introduction of the ACPI-selected console it does not have any sense and I would have to change it anyway. Thank you Aleksey Makarov