From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aleksey Makarov Subject: Re: [PATCH v5 1/6] of/serial: move earlycon early_param handling to serial Date: Tue, 22 Mar 2016 19:55:32 +0300 Message-ID: <56F17904.3070202@linaro.org> References: <1458643595-14719-1-git-send-email-aleksey.makarov@linaro.org> <1458643595-14719-2-git-send-email-aleksey.makarov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org To: Rob Herring Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Len Brown , "linux-serial@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , Leif Lindholm , Graeme Gregory , Al Stone , Christopher Covington , Yury Norov , Peter Hurley , "Zheng, Lv" , Frank Rowand , Grant Likely , Jiri Slaby , "devicetree@vger.kernel.org" List-Id: linux-serial@vger.kernel.org On 03/22/2016 02:15 PM, Rob Herring wrote: > On Tue, Mar 22, 2016 at 5:46 AM, Aleksey Makarov > wrote: >> From: Leif Lindholm >> >> We have multiple "earlycon" early_param handlers - merge the DT one into >> the main earlycon one. It's a cleanup that also will be useful >> to decide if ACPI SPCR earlycon should be set up. > > How so? Isn't that determined by whether we have ACPI tables or a DT? Oops, I missed this. This patch was not only to do parsing in one place, but also to allow addition of code that decide which of ACPI/DT should be used for earlycon initialization based on acpi_disabled. I will fix this, thank you. > This goes against trying to limit places of FDT parsing and keeping > the early scanning all within fdt.c. At least it is not in the arch > code. That said, I'm okay with this change if it helps. > > Rob >