From: Timur Tabi <timur@codeaurora.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Christopher Covington <cov@codeaurora.org>,
Andre Przywara <andre.przywara@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jon Masters <jcm@redhat.com>,
Mark Langsdorf <mlangsdo@redhat.com>,
Dave Martin <dave.martin@linaro.org>,
Aleksey Makarov <aleksey.makarov@linaro.org>
Subject: Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART
Date: Wed, 30 Mar 2016 13:11:17 -0500 [thread overview]
Message-ID: <56FC16C5.70402@codeaurora.org> (raw)
In-Reply-To: <20160330180159.GA24988@kroah.com>
Greg Kroah-Hartman wrote:
> On Wed, Mar 30, 2016 at 12:01:56PM -0500, Timur Tabi wrote:
>> Greg Kroah-Hartman wrote:
>>> If this isn't a bug fix or regression fix, it's not ok for 4.6-final, it
>>> will have to wait for 4.7-rc1.
>>
>> It fixes a problem on our platform (QDF2432). Without this patch, we can't
>> use the PL011 at all.
>
> Did it ever work before? Or is this new functionality?
No, it never worked before, so it's not a regression. I guess it all
depends on how you define "fix". The driver loads and attempts to use
the hardware, but it fails without this patch. The system locks up
completely (I guess it throws an unhandled exception or something).
I guess if you take a very limited definition of "fix", then this isn't
a fix. I can understand if you didn't want to take it for 4.6-rc7 or
something, but for 4.6-rc2, I don't think it's inappropriate.
That's my two cents. We'd like to see it in 4.6-rc2, but the decision
is yours.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.
next prev parent reply other threads:[~2016-03-30 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 5:43 [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART Christopher Covington
2016-03-08 14:51 ` Mark Langsdorf
2016-03-11 6:35 ` Christopher Covington
2016-03-11 15:02 ` Peter Hurley
2016-03-11 23:38 ` [PATCH v2] " Christopher Covington
2016-03-15 10:08 ` [PATCH] " Andre Przywara
2016-03-30 12:30 ` Christopher Covington
2016-03-30 16:55 ` Greg Kroah-Hartman
2016-03-30 17:01 ` Timur Tabi
2016-03-30 18:01 ` Greg Kroah-Hartman
2016-03-30 18:11 ` Timur Tabi [this message]
2016-04-01 21:23 ` [PATCH v3] " Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC16C5.70402@codeaurora.org \
--to=timur@codeaurora.org \
--cc=aleksey.makarov@linaro.org \
--cc=andre.przywara@arm.com \
--cc=cov@codeaurora.org \
--cc=dave.martin@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jcm@redhat.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mlangsdo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).