From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH, RESEND] serial-uartlite: un-constify uartlite_be/uartlite_le Date: Sun, 17 Apr 2016 22:29:51 +0530 Message-ID: <5713C107.5070009@gmail.com> References: <1460851985-1280235-1-git-send-email-arnd@arndb.de> <20160417003901.GA29002@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160417003901.GA29002@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Arnd Bergmann , Peter Korsgaard , Jiri Slaby , Maarten Brock , Rich Felker , Michal Simek , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Sunday 17 April 2016 06:09 AM, Greg Kroah-Hartman wrote: > On Sun, Apr 17, 2016 at 02:12:47AM +0200, Arnd Bergmann wrote: >> The patch to make uartlite_be/uartlite_le const was well-intended but >> caused a new build warning: >> >> tty/serial/uartlite.c: In function 'ulite_request_port': >> tty/serial/uartlite.c:348:21: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] >> tty/serial/uartlite.c:354:22: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] >> >> It would be nice to allow passing const pointers through >> port->private_data, but that would be way more work, so this >> reverts part of the original commit for now. >> >> A possible alternative might be to pass a structure in the private_data >> that contains a const pointer to the operations, which introduces a little >> extra overhead, or we could just add a cast to a non-const pointer, I'll >> leave that to the maintainer. >> >> Signed-off-by: Arnd Bergmann >> Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le") >> --- >> drivers/tty/serial/uartlite.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> I sent this patch on March 10, but it never made it in. >> >> Greg, could you apply the patch as a bugfix for 4.6? The warning is >> annoying as it shows up in several defconfig builds and allmodconfig. > > Ugh, sorry about this, will get to it soon... > A revert patch with the same effect posted on 11th April is also in waiting. http://www.spinics.net/lists/linux-serial/msg22287.html regards sudip