From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2
Date: Fri, 13 May 2016 09:35:18 +0100 [thread overview]
Message-ID: <573591C6.1070106@arm.com> (raw)
In-Reply-To: <1462906570-27684-1-git-send-email-geert+renesas@glider.be>
On 10/05/16 19:56, Geert Uytterhoeven wrote:
> Enabling support for the UART on the ARM MPS2 platform only make sense
> when compiling for the ARM MPS2 platform, unless compile-testing.
What you said is true, but looking around (see SERIAL_STM32 for example)
I'm wondering what makes MPS2 so special flake?
I was under impression that architecture/board specific guard must have
only if we have something like
#include <asm/xyz.h>
or
#include <mach/xyz.h>
which is not a case for device-tree driven MPS2 uart.
I have no idea what is practice for such things, so would be grateful to
get it known.
Cheers
Vladimir
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index b84810aa8621d8b1..3def7478ca44f573 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE
>
> config SERIAL_MPS2_UART
> bool "MPS2 UART port"
> - depends on ARM || COMPILE_TEST
> + depends on ARCH_MPS2 || COMPILE_TEST
> select SERIAL_CORE
> help
> This driver support the UART ports on ARM MPS2.
>
next prev parent reply other threads:[~2016-05-13 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 18:56 [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2 Geert Uytterhoeven
2016-05-13 8:35 ` Vladimir Murzin [this message]
2016-05-13 8:57 ` Geert Uytterhoeven
2016-06-01 12:51 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573591C6.1070106@arm.com \
--to=vladimir.murzin@arm.com \
--cc=andy.shevchenko@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).