[PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2

[PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2

[Geert Uytterhoeven]

Enabling support for the UART on the ARM MPS2 platform only make sense
when compiling for the ARM MPS2 platform, unless compile-testing.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index b84810aa8621d8b1..3def7478ca44f573 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE
 
 config SERIAL_MPS2_UART
 	bool "MPS2 UART port"
-	depends on ARM || COMPILE_TEST
+	depends on ARCH_MPS2 || COMPILE_TEST
 	select SERIAL_CORE
 	help
 	  This driver support the UART ports on ARM MPS2.
-- 
1.9.1

Re: [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2

[Vladimir Murzin]

On 10/05/16 19:56, Geert Uytterhoeven wrote:
> Enabling support for the UART on the ARM MPS2 platform only make sense
> when compiling for the ARM MPS2 platform, unless compile-testing.

What you said is true, but looking around (see SERIAL_STM32 for example)
I'm wondering what makes MPS2 so special flake?

I was under impression that architecture/board specific guard must have
only if we have something like

#include <asm/xyz.h>

or

#include <mach/xyz.h>

which is not a case for device-tree driven MPS2 uart.

I have no idea what is practice for such things, so would be grateful to
get it known.

Cheers
Vladimir

> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index b84810aa8621d8b1..3def7478ca44f573 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1457,7 +1457,7 @@ config SERIAL_MPS2_UART_CONSOLE
>  
>  config SERIAL_MPS2_UART
>  	bool "MPS2 UART port"
> -	depends on ARM || COMPILE_TEST
> +	depends on ARCH_MPS2 || COMPILE_TEST
>  	select SERIAL_CORE
>  	help
>  	  This driver support the UART ports on ARM MPS2.
> 

Re: [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2

[Geert Uytterhoeven]

Hi Vladimir,

On Fri, May 13, 2016 at 10:35 AM, Vladimir Murzin
<vladimir.murzin@arm.com> wrote:
> On 10/05/16 19:56, Geert Uytterhoeven wrote:
>> Enabling support for the UART on the ARM MPS2 platform only make sense
>> when compiling for the ARM MPS2 platform, unless compile-testing.
>
> What you said is true, but looking around (see SERIAL_STM32 for example)
> I'm wondering what makes MPS2 so special flake?

Nothing. SERIAL_STM32 should be fixed, too.
I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.

> I was under impression that architecture/board specific guard must have
> only if we have something like
>
> #include <asm/xyz.h>
>
> or
>
> #include <mach/xyz.h>
>
> which is not a case for device-tree driven MPS2 uart.
>
> I have no idea what is practice for such things, so would be grateful to
> get it known.

That's why there's an "|| COMPILE_TEST" in the dependency.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] serial: Make SERIAL_MPS2_UART depend on ARCH_MPS2

[Vladimir Murzin]

On 13/05/16 09:57, Geert Uytterhoeven wrote:
> Hi Vladimir,
> 
> On Fri, May 13, 2016 at 10:35 AM, Vladimir Murzin
> <vladimir.murzin@arm.com> wrote:
>> On 10/05/16 19:56, Geert Uytterhoeven wrote:
>>> Enabling support for the UART on the ARM MPS2 platform only make sense
>>> when compiling for the ARM MPS2 platform, unless compile-testing.
>>
>> What you said is true, but looking around (see SERIAL_STM32 for example)
>> I'm wondering what makes MPS2 so special flake?
> 
> Nothing. SERIAL_STM32 should be fixed, too.
> I only fixed SERIAL_MPS2_UART, as it was a newly-introduced symbol.
> 
>> I was under impression that architecture/board specific guard must have
>> only if we have something like
>>
>> #include <asm/xyz.h>
>>
>> or
>>
>> #include <mach/xyz.h>
>>
>> which is not a case for device-tree driven MPS2 uart.
>>
>> I have no idea what is practice for such things, so would be grateful to
>> get it known.
> 
> That's why there's an "|| COMPILE_TEST" in the dependency.
> 

First of all sorry for the late response...

Secondly, I have no strong opinion on the patch, so I'd leave the final
word to Greg

FWIW

Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>

Cheers
Vladimir

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
>