From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH v2] serial: 8250_dw: Improve unwritable LCR workaround Date: Tue, 10 Dec 2013 22:48:06 +0000 Message-ID: <5829576.XRqmsfpHkX@radagast> References: <1380647888-32473-1-git-send-email-tim.kryger@linaro.org> <20131210121154.GA16238@localhost> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart9126169.0cbx9Cncuf"; micalg="pgp-sha1"; protocol="application/pgp-signature" Return-path: Received: from mail-we0-f169.google.com ([74.125.82.169]:48799 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030Ab3LJWsS (ORCPT ); Tue, 10 Dec 2013 17:48:18 -0500 Received: by mail-we0-f169.google.com with SMTP id w61so5767433wes.28 for ; Tue, 10 Dec 2013 14:48:17 -0800 (PST) In-Reply-To: <20131210121154.GA16238@localhost> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Ezequiel Garcia , Tim Kryger Cc: Greg Kroah-Hartman , Heikki Krogerus , linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" , Patch Tracking , Thomas Petazzoni , Gregory Clement , Lior Amsalem , Jason Cooper , ARM Kernel List --nextPart9126169.0cbx9Cncuf Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Tuesday 10 December 2013 09:11:55 Ezequiel Garcia wrote: > Hi Tim, James: > > On Mon, Dec 09, 2013 at 04:42:23PM -0800, Tim Kryger wrote: > > On Fri, Dec 6, 2013 at 4:59 PM, James Hogan wrote: > [..] > > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > b/drivers/tty/serial/8250/8250_dw.c > > index 4658e3e..5f096c7 100644 > > --- a/drivers/tty/serial/8250/8250_dw.c > > +++ b/drivers/tty/serial/8250/8250_dw.c > > @@ -96,7 +96,8 @@ static void dw8250_serial_out(struct uart_port *p, > > int offset, int value) > > > > if (offset == UART_LCR) { > > > > int tries = 1000; > > while (tries--) { > > > > - if (value == p->serial_in(p, UART_LCR)) > > + unsigned int lcr = p->serial_in(p, UART_LCR); > > + if ((value & ~UART_LCR_SPAR) == (lcr & > > ~UART_LCR_SPAR))> > > return; > > > > dw8250_force_idle(p); > > writeb(value, p->membase + (UART_LCR << > > p->regshift)); > > > > @@ -132,7 +133,8 @@ static void dw8250_serial_out32(struct uart_port > > *p, int offset, int value) > > > > if (offset == UART_LCR) { > > > > int tries = 1000; > > while (tries--) { > > > > - if (value == p->serial_in(p, UART_LCR)) > > + unsigned int lcr = p->serial_in(p, UART_LCR); > > + if ((value & ~UART_LCR_SPAR) == (lcr & > > ~UART_LCR_SPAR))> > > return; > > > > dw8250_force_idle(p); > > writel(value, p->membase + (UART_LCR << > > p->regshift)); > > > > Would you mind posting this for proper review so we can get the fix in? > > Applying this change fixes all the problems I reported (just did a quick > test on the board I have currently on my desk). > > Nice work! Thanks for testing it. I've posted Tim's version for proper review with both your tested-by. Cheers James --nextPart9126169.0cbx9Cncuf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABAgAGBQJSp5ouAAoJEKHZs+irPybfaR8P/R6SrFsvocrdOCjNVdkWXuPF NG27O5MVE1WvjvTuWmsd89NxZhBRquK31gi9qSr/uPzy9v5azu4FBgWJUqlIvpQN JpYwcWHmkUF15fFyXK7AXu6VQ4DgVEnc33xPRS6Ym4U0/BTX91eNvrqzyblQ9OhA 6KvRp8rC+dqRJw6+xIX18PgH8/mu2SLOVD7W3XbOo43T5t2B5x1DoTgmgQloafTM w3R+0wfN12NJSsw/wjTonLa6DYQQl96MfbvAF98sMai20Rdtt5dt4irtDu9TMjZP GhKbRVfJxgWjq5R5wo2oa1r/YypymPUW3TJEa/kWcNmSq9DJlRWekBbWgY8+8Fjf H/LXdVzlM6ArpcirQHV2g1EaMWGo4lwAkwSLx0GcvH36oQlcUUSxsGtmp40wNhF1 8/8WO+pZIYNdE2JorZyEBnGoygTJ/SF1Xd8YgY0o5KFAXkLXCSMCPyPFgroD+zWA X4jr2qu5dw2Gmni5vPJkrVPmYOYGSkxk5fH2iux35iTiLpDHk+TEcZN2jd7R+ZDP EbGTkdzKlqsqUsLsvznhecHrseTjs7A0R2FMH60mNUIVKkoZ27KD+zcLDOvSqDNe xelMde1EX98cCYUK1q+PiYUcgyF/Am4hkmU610tSfZUibIIovcRHEGpdtNvWAuOt idqLTtgprnKlf50UDpA/ =QdKq -----END PGP SIGNATURE----- --nextPart9126169.0cbx9Cncuf--