From: Pavel Skripkin <paskripkin@gmail.com>
To: Ajay Garg <ajaygargnsit@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
jirislaby@kernel.org, kernel@esmil.dk,
David Laight <David.Laight@aculab.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty: vt: keyboard: do not copy an extra-byte in copy_to_user
Date: Sat, 6 Nov 2021 22:56:33 +0300 [thread overview]
Message-ID: <58f5cf69-3b3b-62f2-9f73-49c51176a534@gmail.com> (raw)
In-Reply-To: <CAHP4M8Ww0-VqCBKX=iLd=zy1AcDoNdzTOqJuaqRxCGZsMhoX9w@mail.gmail.com>
On 11/6/21 22:20, Ajay Garg wrote:
> I vote for David's strscpy "fix", as it is simple, and does away with
> the dependency on the length of "func_table[kb_func]".
>
strscpy fix sounds reasonable to me. just to be save in future.
There is only one thing I am wondering about: translation table entries
are set by user using this struct
struct kbsentry {
unsigned char kb_func;
unsigned char kb_string[512];
};
it means entries cannot be longer than sizeof(kbsentry::kb_string) - 1
at all. Do we need extra branching with strscpy() or do we need to do
anything else here?
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-11-06 19:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 9:20 [PATCH] tty: vt: keyboard: do not copy an extra-byte in copy_to_user Ajay Garg
2021-11-06 11:23 ` Pavel Skripkin
2021-11-06 12:05 ` Ajay Garg
2021-11-06 12:39 ` Pavel Skripkin
2021-11-06 16:40 ` David Laight
2021-11-06 19:20 ` Ajay Garg
2021-11-06 19:46 ` Ajay Garg
2021-11-06 20:18 ` Pavel Skripkin
2021-11-06 20:30 ` Ajay Garg
2021-11-06 20:34 ` Pavel Skripkin
2021-11-06 20:44 ` Ajay Garg
2021-11-06 20:48 ` Pavel Skripkin
2021-11-08 8:59 ` Ajay Garg
2021-11-08 11:58 ` Pavel Skripkin
2021-11-08 12:12 ` Ajay Garg
2021-11-10 5:22 ` Jiri Slaby
2021-11-10 7:37 ` Pavel Skripkin
2021-11-10 8:57 ` Ajay Garg
2021-11-10 9:06 ` Greg KH
2021-11-10 9:32 ` Ajay Garg
2021-11-06 19:56 ` Pavel Skripkin [this message]
2021-11-06 20:07 ` Ajay Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58f5cf69-3b3b-62f2-9f73-49c51176a534@gmail.com \
--to=paskripkin@gmail.com \
--cc=David.Laight@aculab.com \
--cc=ajaygargnsit@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@esmil.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox