From: Florian Fainelli <f.fainelli@gmail.com>
To: Guo Mengqi <guomengqi3@huawei.com>, gregkh@linuxfoundation.org
Cc: jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com,
athierry@redhat.com, linux-serial@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, xuqiang36@huawei.com
Subject: Re: [PATCH -next v3] serial: 8250_bcm2835aux: Add missing clk_disable_unprepare()
Date: Thu, 14 Jul 2022 19:41:02 -0700 [thread overview]
Message-ID: <5c4ddf6d-3f6c-b64e-5503-0f8cad4a9364@gmail.com> (raw)
In-Reply-To: <20220715023312.37808-1-guomengqi3@huawei.com>
On 7/14/2022 7:33 PM, Guo Mengqi wrote:
> The error path when get clock frequency fails in bcm2835aux_serial
> driver does not correctly disable the clock.
>
> This flaw was found using a static analysis tool "Hulk Robot", which
> reported the following warning when analyzing linux-next/master:
>
> drivers/tty/serial/8250/8250_bcm2835aux.c:
> warning: clk_disable_unprepare_missing.cocci
>
> The cocci script checks for the existence of clk_disable_unprepare()
> paired with clk_prepare_enable().
>
> Add the missing clk_disable_unprepare() to the error path.
>
> Fixes: fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2022-07-15 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 2:58 [PATCH -next] drivers/tty/serial: Add missing clk_disable_unprepare() Guo Mengqi
2022-06-27 12:06 ` Greg KH
2022-07-06 3:00 ` [PATCH -next v2] serial: 8250_bcm2835aux: " Guo Mengqi
2022-07-12 3:35 ` [PATCH -next] drivers/tty/serial: " Florian Fainelli
2022-07-13 7:37 ` guomengqi (A)
2022-07-15 2:33 ` [PATCH -next v3] serial: 8250_bcm2835aux: " Guo Mengqi
2022-07-15 2:41 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c4ddf6d-3f6c-b64e-5503-0f8cad4a9364@gmail.com \
--to=f.fainelli@gmail.com \
--cc=athierry@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=guomengqi3@huawei.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).