From: Stephen Boyd <swboyd@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mgautam@codeaurora.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH V2 2/2] tty: serial: qcom_geni_serial: Wakeup over UART RX
Date: Tue, 15 Oct 2019 13:10:17 -0700 [thread overview]
Message-ID: <5da627aa.1c69fb81.e2d51.203d@mx.google.com> (raw)
In-Reply-To: <a7dabb1d-b6af-acc5-ba4e-923ee5fc6ee3@codeaurora.org>
Quoting Akash Asthana (2019-10-11 02:48:42)
>
> On 10/10/2019 7:55 PM, Stephen Boyd wrote:
> > Quoting Akash Asthana (2019-10-10 02:46:43)
> >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> >> index 5180cd8..ff63728 100644
> >> --- a/drivers/tty/serial/qcom_geni_serial.c
> >> +++ b/drivers/tty/serial/qcom_geni_serial.c
> >> @@ -1306,6 +1317,29 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
> >> + if (port->wakeup_irq < 0) {
> >> + dev_err(&pdev->dev, "Failed to get wakeup IRQ %d\n",
> >> + port->wakeup_irq);
> >> + } else {
> >> + irq_set_status_flags(port->wakeup_irq, IRQ_NOAUTOEN);
> >> + ret = devm_request_irq(uport->dev, port->wakeup_irq,
> >> + qcom_geni_serial_wakeup_isr,
> >> + IRQF_TRIGGER_FALLING, "uart_wakeup", uport);
> >> + if (ret) {
> >> + dev_err(uport->dev, "Failed to register wakeup IRQ ret %d\n",
> >> + ret);
> >> + return ret;
> >> + }
> >> +
> >> + device_init_wakeup(&pdev->dev, true);
> >> + ret = dev_pm_set_wake_irq(&pdev->dev, port->wakeup_irq);
> > Why can't we use dev_pm_set_dedicated_wake_irq() here?
>
> If we use this API then handler "handle_threaded_wake_irq" uses device
> specific pm_runtime functions to wake the device and currently this
>
> driver don't support runtime PM callbacks. Also, we want to register
> "qcom_geni_serial_wakeup_isr" as our IRQ handler for wakeup scenario.
>
Why can't we make this driver use runtime PM?
next prev parent reply other threads:[~2019-10-15 20:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 9:46 [PATCH V2 2/2] tty: serial: qcom_geni_serial: Wakeup over UART RX Akash Asthana
2019-10-10 14:25 ` Stephen Boyd
2019-10-11 9:48 ` Akash Asthana
2019-10-15 20:10 ` Stephen Boyd [this message]
2019-10-17 11:10 ` Akash Asthana
2019-10-28 15:00 ` Stephen Boyd
2019-11-05 9:56 ` Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5da627aa.1c69fb81.e2d51.203d@mx.google.com \
--to=swboyd@chromium.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).