From: Krzysztof Kozlowski <krzk@kernel.org>
To: Benjamin Larsson <benjamin.larsson@genexis.eu>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org
Cc: ansuelsmth@gmail.com, lorenzo@kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles
Date: Sat, 11 Jan 2025 14:27:57 +0100 [thread overview]
Message-ID: <606db6ae-bed0-4c35-967c-303b6277b716@kernel.org> (raw)
In-Reply-To: <20250111132250.3642694-2-benjamin.larsson@genexis.eu>
On 11/01/2025 14:22, Benjamin Larsson wrote:
> The Airoha SoC family have a mostly 16550-compatible UART
> and High-Speed UART hardware with the exception of custom
> baud rate settings register.
>
> compatible = "airoha,airoha-uart";
> compatible = "airoha,airoha-hsuart";
I don't understand these, not helping to understand the commit at all.
Do not describe DT syntax in commit msg, it's obvious.
BTW, that's not correct address you are supposed to CC. Please use
scripts/get_maintainers.pl to get a list of necessary people and lists
to CC. Or switch to `b4`.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-11 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 13:22 [PATCH v2 0/2] Airoha UART support Benjamin Larsson
2025-01-11 13:22 ` [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles Benjamin Larsson
2025-01-11 13:27 ` Krzysztof Kozlowski [this message]
2025-01-11 13:38 ` Benjamin Larsson
2025-01-11 13:22 ` [PATCH 2/2] serial: Airoha SoC UART and HSUART support Benjamin Larsson
2025-01-12 10:54 ` kernel test robot
2025-01-12 13:04 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-02-09 21:02 [PATCH v4 0/2] Airoha UART support Benjamin Larsson
2025-02-09 21:02 ` [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles Benjamin Larsson
2025-01-19 13:01 [PATCH v3 0/2] Airoha UART support Benjamin Larsson
2025-01-19 13:01 ` [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles Benjamin Larsson
2025-01-20 7:57 ` Krzysztof Kozlowski
2025-01-20 12:59 ` Benjamin Larsson
2025-01-20 15:03 ` Krzysztof Kozlowski
2025-01-20 15:46 ` Benjamin Larsson
2025-01-20 16:44 ` Krzysztof Kozlowski
2025-01-05 13:11 [PATCH 0/2] Airoha UART support Benjamin Larsson
2025-01-05 13:11 ` [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles Benjamin Larsson
2025-01-06 7:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606db6ae-bed0-4c35-967c-303b6277b716@kernel.org \
--to=krzk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox