Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Dustin Lundquist <dustin@null-ptr.net>
To: linux-serial@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
Subject: [PATCH] serial: jsm: fix NPE during jsm_uart_port_init
Date: Mon, 5 May 2025 11:18:34 -0700	[thread overview]
Message-ID: <613DBD1A-3BD8-45B9-BF90-75E907CBE859@null-ptr.net> (raw)

No driver was set which caused serial_base_ctrl_add to crash.

Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
Signed-off-by: Dustin Lundquist <dustin@null-ptr.net>
---
drivers/tty/serial/jsm/jsm_tty.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/jsm/jsm_tty.c b/drivers/tty/serial/jsm/jsm_tty.c
index ce0fef7e2c66..be2f130696b3 100644
--- a/drivers/tty/serial/jsm/jsm_tty.c
+++ b/drivers/tty/serial/jsm/jsm_tty.c
@@ -451,6 +451,7 @@ int jsm_uart_port_init(struct jsm_board *brd)
		if (!brd->channels[i])
			continue;

+		brd->channels[i]->uart_port.dev = &brd->pci_dev->dev;
		brd->channels[i]->uart_port.irq = brd->irq;
		brd->channels[i]->uart_port.uartclk = 14745600;
		brd->channels[i]->uart_port.type = PORT_JSM;
-- 
2.47.2

             reply	other threads:[~2025-05-05 18:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 18:18 Dustin Lundquist [this message]
2025-05-06  4:27 ` [PATCH] serial: jsm: fix NPE during jsm_uart_port_init Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=613DBD1A-3BD8-45B9-BF90-75E907CBE859@null-ptr.net \
    --to=dustin@null-ptr.net \
    --cc=linux-serial@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox