From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: samsung: add dedicated compatible for exynosauto SoCs
Date: Fri, 24 Apr 2026 18:12:15 +0200 [thread overview]
Message-ID: <6916bf87-4c40-42c5-988f-92a57a6fc658@kernel.org> (raw)
In-Reply-To: <20260424101835.2125970-1-alim.akhtar@samsung.com>
On 24/04/2026 12:18, Alim Akhtar wrote:
> Currently Exynosautov-{9,920} getting probed based on exynos850
> fallback. It is recommended to have a dedicated compatible for
> proper driver binding.
Unfortunately it is not. Dedicated compatible you have. However you are
not adding dedicated compatible. You added dedicated driver match entry
and we, and especially me, gave reviews many times that it is *not
recommended* to have dedicated driver match entry.
Entire reasoning for doing this patch is wrong. And patch itself is NOOP
(at least by quick look).
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-24 16:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260424100201epcas5p371dd69955076938ee41ed0d823433056@epcas5p3.samsung.com>
2026-04-24 10:18 ` [PATCH] tty: serial: samsung: add dedicated compatible for exynosauto SoCs Alim Akhtar
2026-04-24 16:12 ` Krzysztof Kozlowski [this message]
2026-04-26 17:18 ` Alim Akhtar
2026-04-27 6:40 ` Krzysztof Kozlowski
2026-04-27 10:26 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6916bf87-4c40-42c5-988f-92a57a6fc658@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox