From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793099971; b=cSNpHl53sD1Oxq8MdVafWDDafE5GqHJboFbCJh+XK/fC+v+1CzOrMGLyaarDCc7il9C9 ircAd0kAuZ+DP+HiCQGDOlqysDRG8a/j/gFTlqtmNG0VtP2ml0heWy5jP6obES+pBM2mx TmkYqwM914z//WJQQDIH7itRj3F3v3AaetK/5mhMiN0Pt+g+XW0aU4YjGO6y8j4tHuu/o W+HO9Z4nkYEeAK86VousNoP0I7nbHQY5qHVIGrOeSdL2j7G43IoMA4z43/onpfGQNmH6S 7TKJt+wzy1DJ4NdIEgwCZWJTvlwweRPXop4g2UinUZzw53rRyP1lAhvAfrzq11hM1ng== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793099971; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=A7yFeNmixC1qpGLop/XKM8z6oKyDB+AHSkeaELStkWg=; b=y4+bRKElGB5PXbCpOVghwTEZiaNUFxEGetpjr6mfjvZ9OPKDqVSAWG07cnwDlUmVc0na dHdrcpYIm1TyD+sggMUWEooK11tmSHqQWc7AB5JR6Pd95f9NYrZjm/6WDd5L6vkqiJ6Nr OqW62k+/GdLbbX+pTVAj+k05zINVyQ7AfTSdZZlTSUOc9Ttc3Yqv6LiOP/zeV4pRuG0G6 ybmCuWeHcfaJrJpyc0hBdz6nrKHOCBignQxDt4jwRnONYGhUdoRR8JNllD1heGRF4NA+g G/IYMgNhifeVJr5gV7RKZ6/D5YdFG6TDegOAYnPmvHCS00ISDl/JxWhMv2e+NPtn35Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=T7H5vjk6; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A840606A31B; Tue, 27 Oct 2026 11:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=T7H5vjk6 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B53A1F01825; Tue, 27 Oct 2026 11:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793099971; bh=A7yFeNmixC1qpGLop/XKM8z6oKyDB+AHSkeaELStkWg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=T7H5vjk6gpsyNRrD/1XAIooRwghIE0RHIJz1VjipAohsRN1z6ZlOvOoFafSs4CNr4 BVuIswLDUcrFYnqbuod7qyqyM2dQditzlV25/lv+oldQO/8cNOO0whC/sc4X12B4vB Bsp4L8MCbQv2DdQ6pISwEy0/b8NpUJ0WU/Jve4gl7HTh50PlZs5fU2ztFl+HIvIimA WFfyDiJLpOeWJ3dKUtOXLAtr+7gNvdmfNbsBxI5hwrGzLeVSNut8uloG9zqZmfx5io dkRdK57KqNt0DnbrDmjkc8hmYBfEv/6tfyapSWVP+u5L3INa+Y8M/kkUT+AEYlStJj CCg77t0vGxDTA== Message-ID: <69b980a0-8499-45aa-b112-76d3739a5e11@kernel.org> Date: Tue, 27 Oct 2026 12:19:28 +0100 X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/24] serial: 8250: add bounds check for line array in setup_serial() To: sashiko-reviews@lists.linux.dev, Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org References: <20261027-tty-llm-v1-0-99b0202ae546@linuxfoundation.org> <20261027-tty-llm-v1-6-99b0202ae546@linuxfoundation.org> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27. 10. 26, 12:12, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] serial: 8250: build failure in setup_serial() due to non-existent info->line > -- > > commit a2e0e82dd3bc2dcce54251c9832007f4a9e30584 > Author: Joshua Rogers > > serial: 8250: add bounds check for line array in setup_serial() > > This commit adds a bounds check in setup_serial() to prevent out-of-bounds > writes when registering serial ports for a PCMCIA card. > >> diff --git a/drivers/tty/serial/8250/serial_cs.c b/drivers/tty/serial/8250/serial_cs.c >> index 5dcd1544e478d..8bd88f3d6d865 100644 >> --- a/drivers/tty/serial/8250/serial_cs.c >> +++ b/drivers/tty/serial/8250/serial_cs.c >> @@ -349,6 +349,11 @@ static int setup_serial(struct pcmcia_device *handle, struct serial_info *info, >> { >> struct uart_8250_port uart; >> >> + if (info->ndev >= ARRAY_SIZE(info->line)) { >> + dev_err(&handle->dev, "no room for more serial ports\n"); >> + return -EINVAL; >> + } > > [Severity: Low] > Does this break the build when CONFIG_SERIAL_8250_CS is enabled? > > Commit d6a0791098be ("serial: 8250: make port operations work on struct > uart_8250_port") replaced line[4] with uport[4] in struct serial_info in > drivers/tty/serial/8250/serial_cs.c: > > struct serial_info { > ... > struct uart_8250_port *uport[4]; > const struct serial_quirk *quirk; > }; > > and updated setup_serial() to store the registered port in info->uport: > > info->uport[info->ndev] = serial8250_register_8250_port(&uart); > > Because struct serial_info no longer has a member named line, referencing > info->line in ARRAY_SIZE() fails to compile. Should this check > ARRAY_SIZE(info->uport) instead? ACK, it should thanks, -- js suse labs