From: msavaliy@codeaurora.org
To: Douglas Anderson <dianders@chromium.org>
Cc: gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
alokc@codeaurora.org, mka@chromium.org, evgreen@chromium.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.com>,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb
Date: Wed, 17 Oct 2018 13:04:10 +0530 [thread overview]
Message-ID: <6a4b57b252c01d312be10ce586be7d7d@codeaurora.org> (raw)
In-Reply-To: <20181015204425.84537-1-dianders@chromium.org>
On 2018-10-16 02:14, Douglas Anderson wrote:
> If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
> selected.
>
> If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
> was setting RX_BYTES_PW to 1 for _all_ UART ports.
>
> This doesn't seem like such a good idea. Let's only set RX_BYTES_PW
> to 1 for the console port.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/tty/serial/qcom_geni_serial.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
Good finding, Makes sense to keep changes this way for console only
port.
Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
prev parent reply other threads:[~2018-10-17 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 20:44 [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb Douglas Anderson
2018-10-16 20:53 ` Stephen Boyd
2018-10-17 7:34 ` msavaliy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a4b57b252c01d312be10ce586be7d7d@codeaurora.org \
--to=msavaliy@codeaurora.org \
--cc=alokc@codeaurora.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).